Changes to support the new substreams construct for MUX flows#61
Draft
cristian-recoseanu wants to merge 5 commits intomainfrom
Draft
Changes to support the new substreams construct for MUX flows#61cristian-recoseanu wants to merge 5 commits intomainfrom
cristian-recoseanu wants to merge 5 commits intomainfrom
Conversation
Contributor
cristian-recoseanu
commented
Oct 17, 2023
cristian-recoseanu
commented
- Update constraint_set.json to include the new "urn:x-nmos:substreams" attribute as specified by BCP-004-01 revision
- Update README.md to include a new section describing substreams
to include the new "urn:x-nmos:substreams" attribute as specified by BCP-004-01 revision
To include section describing substreams
To move the substreams definition right after the meta attributes
Contributor
peterbrightwell
left a comment
peterbrightwell
left a comment
There was a problem hiding this comment.
Looks good. Suggest review use of capitalisation ("Mux", "Flow", etc)
Contributor
Author
Addressed in commit e6e092e |
garethsb
reviewed
Oct 30, 2023
Comment on lines
+256
to
+257
| Mux Senders create IS-04 Flow objects for each subflow included in the mux Flow. | ||
| The mux Flow links to each subflow object using the IS-04 [`parents`](https://specs.amwa.tv/is-04/latest/docs/Data_Model_-_Identifier_Mapping.html#source-and-flow-representation) attribute. |
Contributor
There was a problem hiding this comment.
Suggested change
| Mux Senders create IS-04 Flow objects for each subflow included in the mux Flow. | |
| The mux Flow links to each subflow object using the IS-04 [`parents`](https://specs.amwa.tv/is-04/latest/docs/Data_Model_-_Identifier_Mapping.html#source-and-flow-representation) attribute. | |
| Mux Senders create IS-04 Flow resources for each subflow included in the mux Flow. | |
| The mux Flow links to each subflow resource using the IS-04 [`parents`](https://specs.amwa.tv/is-04/latest/docs/Data_Model_-_Identifier_Mapping.html#source-and-flow-representation) attribute. |
(Generally we haven't used latest URL but linked to a particular spec version.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.