Open
Conversation
mmaybei
requested review from
ChoiAnYong,
bangMinjI98,
hongseekim and
sozohoy
sozohoy
approved these changes
Dec 2, 2024
Member
sozohoy
left a comment
sozohoy
left a comment
There was a problem hiding this comment.
깔끔한 코드 잘 보고갑니다!
예제로 남겨주신 레포 더 많은 사람들이 볼 수 있게 공유해주세요 :)
Comment on lines
+104
to
+117
| var downloadButtonFont: Font { | ||
| switch popularApp.downloadState { | ||
| case .paid(_): | ||
| return .system(size: 14, weight: .bold) | ||
| default: | ||
| return .system(size: 16, weight: .bold) | ||
| } | ||
| } | ||
|
|
||
| func formatPrice(_ price: Int) -> String { | ||
| let formatter = NumberFormatter() | ||
| formatter.numberStyle = .decimal | ||
| return formatter.string(from: NSNumber(value: price)) ?? "\(price)" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥Pull requests
⛳️ 작업한 브랜치:
feat/#10-week06📟 관련 이슈: #10
👷 작업한 내용
💻 주요 코드
SwiftUI로 구현된 뷰를 hostingController를 통해 연결해주었습니다!
요 경우 UINavigationController가 UIHostingController를 관리하기 때문에 addChild를 하지 않았지만, 뷰 컨트롤러 간에 부모-자식 관계를 명시적으로 설정해야 하는 상황(예를 들면 뷰 컨트롤러를 서브뷰로 추가할 때)이라면 addChild를 명시해줘야 할 것 같습니다!
📸 스크린샷
🚨 참고 사항