Skip to content

fixed RViz crash if flat height layer is invalid #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed RViz crash if flat height layer is invalid #384

wants to merge 1 commit into from

Conversation

simongiegerich
Copy link

fixes #161

Fixes these bugs:

  • RViz crashes if the Height Transformer is set to Flat while the Height Layer is invalid.
  • RViz crashes if the Color Transformer is set to None while the Color Layer is invalid.

@simongiegerich simongiegerich force-pushed the fix/grid_map_rviz_plugin/rviz_crash_invalid_layer branch from 721130d to ad93987 Compare February 6, 2023 16:15
fvina-anybotics
fvina-anybotics approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@fvina-anybotics fvina-anybotics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Ryanf55 Ryanf55 added the ros1 Affects ROS 1 label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@fvina-anybotics fvina-anybotics fvina-anybotics approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ros1 Affects ROS 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rviz display crash when layer is not available
3 participants
@simongiegerich @fvina-anybotics @Ryanf55