fix(hooks): Claude never saw hook messages — systemMessage is user-only #135
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -203,8 +203,11 @@ elif [[ "$VIOLATION_COUNT" -eq 0 ]]; then | |
| echo -e "${YELLOW}WARNINGS|$WARNING_COUNT warnings (review recommended)${NC}" | ||
| exit 0 | ||
| else | ||
| # Exit code 2 = blocking error, stderr is fed to Claude | ||
| echo "COMMIT INTEGRITY: $VIOLATION_COUNT violations found. Fix these before committing:" >&2 | ||
| for v in "${VIOLATIONS[@]}"; do | ||
| echo " - $v" >&2 | ||
| done | ||
| echo "These patterns indicate shortcuts that will cause problems later." >&2 | ||
|
Comment on lines
+206
to
+211
There was a problem hiding this comment. In the blocking path, the hook relies on |
||
| exit 2 | ||
| fi | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -164,19 +164,8 @@ CONSECUTIVE=$(cat "$STRUGGLE_COUNT_FILE" 2>/dev/null || echo "0") | |
| done | ||
| } >> "$STRUGGLE_FILE" | ||
|
|
||
| # Note: No JSON output needed here. The struggle-inject.sh (UserPromptSubmit) | ||
| # reads .blackboard/.struggle-count and injects additionalContext to Claude | ||
| # on the next prompt. This async Stop hook only does analysis + blackboard writes. | ||
|
Comment on lines
+171
to
+173
There was a problem hiding this comment. This section now intentionally produces no JSON output, but the surrounding section header/comments still describe "OUTPUT SUGGESTION IF THRESHOLD MET". Updating the header/comments to match the new behavior will avoid confusion when maintaining the hook. |
||
|
|
||
| exit 0 | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,49 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| #!/usr/bin/env bash | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # ============================================================================= | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # STRUGGLE INJECT - Delivers struggle detection to Claude via UserPromptSubmit | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # ============================================================================= | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Trigger: UserPromptSubmit (before Claude processes the next prompt) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Purpose: Read blackboard state from async struggle-detector and inject | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # suggestion as additionalContext so Claude actually sees it. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # The struggle-detector.sh (Stop, async) writes scoring data to: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # .blackboard/.struggle-count — consecutive struggling responses | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # .blackboard/.struggle-signals — detailed signal log | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # This hook reads those files and injects context when threshold is met. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # After injection, resets the counter to prevent repeated suggestions. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # ============================================================================= | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| set -euo pipefail | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| PLUGIN_ROOT="${CLAUDE_PLUGIN_ROOT:-}" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| [[ -z "$PLUGIN_ROOT" ]] && exit 0 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| BLACKBOARD="$PLUGIN_ROOT/.blackboard" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| STRUGGLE_COUNT_FILE="$BLACKBOARD/.struggle-count" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Check consecutive struggle count | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| CONSECUTIVE=$(cat "$STRUGGLE_COUNT_FILE" 2>/dev/null || echo "0") | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| [[ "$CONSECUTIVE" -lt 2 ]] && exit 0 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+26
to
+27
There was a problem hiding this comment.
Useful? React with 👍 / 👎. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Read recent signals for context | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| SIGNALS_FILE="$BLACKBOARD/.struggle-signals" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| RECENT_SIGNALS="" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if [[ -f "$SIGNALS_FILE" ]]; then | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| RECENT_SIGNALS=$(tail -20 "$SIGNALS_FILE" | grep ' - ' | sed 's/ - //' | tr '\n' ', ' | sed 's/, $//') | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| RECENT_SIGNALS=$(tail -20 "$SIGNALS_FILE" | grep ' - ' | sed 's/ - //' | tr '\n' ', ' | sed 's/, $//') | |
| RECENT_SIGNALS=$((tail -20 "$SIGNALS_FILE" | grep ' - ' || true) | sed 's/ - //' | tr '\n' ', ' | sed 's/, $//') |
Outdated
There was a problem hiding this comment.
While the current implementation is likely safe because the $RECENT_SIGNALS variable is constructed from known-safe strings, it's fragile. If a future change to struggle-detector.sh introduces signals containing special characters (like double quotes), it could break the JSON output. Using jq to construct the JSON is a more robust and secure approach that prevents potential injection vulnerabilities.
| cat <<EOF | |
| { | |
| "hookSpecificOutput": { | |
| "hookEventName": "UserPromptSubmit", | |
| "additionalContext": "STRUGGLE DETECTOR ($CONSECUTIVE consecutive uncertain responses): Signals — $RECENT_SIGNALS. Consider spawning a deep-think-partner agent (Task tool, subagent_type='deep-think-partner') for thorough analysis instead of continuing to iterate." | |
| } | |
| } | |
| EOF | |
| CONTEXT_MSG="STRUGGLE DETECTOR ($CONSECUTIVE consecutive uncertain responses): Signals — $RECENT_SIGNALS. Consider spawning a deep-think-partner agent (Task tool, subagent_type='deep-think-partner') for thorough analysis instead of continuing to iterate." | |
| # Use jq to safely construct the JSON output. | |
| jq -n \ | |
| --arg context "$CONTEXT_MSG" \ | |
| '{ | |
| "hookSpecificOutput": { | |
| "hookEventName": "UserPromptSubmit", | |
| "additionalContext": $context | |
| } | |
| }' |
Outdated
There was a problem hiding this comment.
The $RECENT_SIGNALS variable is directly interpolated into the JSON output without escaping. If the signals file contains special characters like quotes or newlines, this could break the JSON structure or allow injection attacks.
Consider using jq to properly escape the variable, similar to how truth-beacon.sh handles context injection (line 72 of truth-beacon.sh uses jq -n --arg ctx "$CONTEXT"). For example:
jq -n --arg consecutive "$CONSECUTIVE" --arg signals "$RECENT_SIGNALS" '{
hookSpecificOutput: {
hookEventName: "UserPromptSubmit",
additionalContext: "STRUGGLE DETECTOR (\($consecutive) consecutive uncertain responses): Signals — \($signals). Consider spawning a deep-think-partner agent (Task tool, subagent_type='\''deep-think-partner'\'') for thorough analysis instead of continuing to iterate."
}
}'| cat <<EOF | |
| { | |
| "hookSpecificOutput": { | |
| "hookEventName": "UserPromptSubmit", | |
| "additionalContext": "STRUGGLE DETECTOR ($CONSECUTIVE consecutive uncertain responses): Signals — $RECENT_SIGNALS. Consider spawning a deep-think-partner agent (Task tool, subagent_type='deep-think-partner') for thorough analysis instead of continuing to iterate." | |
| } | |
| } | |
| EOF | |
| jq -n --arg consecutive "$CONSECUTIVE" --arg signals "$RECENT_SIGNALS" '{ | |
| hookSpecificOutput: { | |
| hookEventName: "UserPromptSubmit", | |
| additionalContext: "STRUGGLE DETECTOR (\($consecutive) consecutive uncertain responses): Signals — \($signals). Consider spawning a deep-think-partner agent (Task tool, subagent_type='\''deep-think-partner'\'') for thorough analysis instead of continuing to iterate." | |
| } | |
| }' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
action: warnrules for PreToolUse are currently dropped (function returns{}for warnings whenhook_eventisPreToolUse). This makes warnings effectively no-op for the most common hook path, and contradicts the documented "warn but allow" behavior. Consider emitting a user-visible warning (e.g., viasystemMessage) or, if supported by the Claude Code hooks spec, returning a PreToolUsehookSpecificOutputwithpermissionDecision: "allow"plus a reason field so Claude can see the warning without blocking.