feat: add code-simplifier plugin (qyl-tuned, replaces Anthropic original)#157
feat: add code-simplifier plugin (qyl-tuned, replaces Anthropic original)#157
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new code-simplifier plugin, which is language-agnostic and based on specific engineering principles. The changes include adding the plugin's definition, agent instructions, and documentation, as well as updating the marketplace manifest and changelog. The implementation is well-structured and the documentation is clear. I have one critical point of feedback regarding the Python version requirement in the newly added pyproject.toml file, which would prevent the project from being installed.
Note: Security Review has been skipped due to the limited scope of the PR.
| [project] | ||
| name = "ancplua-claude-plugins" | ||
| version = "0.1.0" | ||
| requires-python = ">=3.14" |
There was a problem hiding this comment.
The specified Python version requires-python = ">=3.14" is invalid as Python 3.14 has not been released. This will prevent the project from being installed with any current Python version. Please specify a requirement for a released Python version, for example >=3.12.
| requires-python = ">=3.14" | |
| requires-python = ">=3.12" |
There was a problem hiding this comment.
Pull request overview
This PR adds a new code-simplifier plugin to the Claude Code plugin marketplace. The plugin provides a language-agnostic code simplification agent tuned to "qyl engineering principles," replacing Anthropic's JS/React-centric code-simplifier. The agent measures code elegance as problem-complexity divided by solution-complexity and emphasizes principles like zero suppression tolerance and compile-time over runtime safety. The PR also includes an unrelated pyproject.toml addition.
Changes:
- New plugin
plugins/code-simplifier/with a plugin manifest, one Opus agent definition, and a README - Updated
marketplace.jsonto register the new plugin (11→12 plugins, 24→25 agents) - Updated
CHANGELOG.mdwith the new plugin entry under[Unreleased]
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
plugins/code-simplifier/.claude-plugin/plugin.json |
Plugin manifest with required fields, keywords, and agent declaration |
plugins/code-simplifier/agents/code-simplifier.md |
Agent definition with simplification principles, workflow steps, and constraints |
plugins/code-simplifier/README.md |
User-facing documentation with philosophy, comparison table, and usage |
.claude-plugin/marketplace.json |
Registers code-simplifier as the 12th plugin, updates description counts |
CHANGELOG.md |
Adds entry for code-simplifier under [Unreleased] → Added |
pyproject.toml |
New top-level Python project file (unrelated to the plugin) |
|
|
||
| ## Usage | ||
|
|
||
| The agent activates when the skill `simplify` is invoked. It reads the project's CLAUDE.md, identifies recent changes, scores elegance, and simplifies candidates. |
There was a problem hiding this comment.
The README claims "The agent activates when the skill simplify is invoked," but no simplify skill exists in this plugin — there is no skills/ directory, no SKILL.md, and no "skills" entry in plugin.json. Either create a skills/simplify/SKILL.md (and declare "skills": "./skills" in plugin.json, per the convention in plugins/exodia/.claude-plugin/plugin.json and plugins/otelwiki/.claude-plugin/plugin.json), or update this line to accurately describe how the agent is invoked (e.g., by referencing the agent directly).
| The agent activates when the skill `simplify` is invoked. It reads the project's CLAUDE.md, identifies recent changes, scores elegance, and simplifies candidates. | |
| Use the `code-simplifier` agent to read the project's CLAUDE.md, identify recent changes, score elegance, and simplify candidates. |
| [project] | ||
| name = "ancplua-claude-plugins" | ||
| version = "0.1.0" | ||
| requires-python = ">=3.14" | ||
| dependencies = [] |
There was a problem hiding this comment.
The pyproject.toml is not mentioned in the PR description, which describes only the code-simplifier plugin, marketplace.json, and CHANGELOG.md changes. This file is unrelated to the code-simplifier plugin being added and appears to be an unrelated change bundled into this PR. Additionally, requires-python = ">=3.14" is very aggressive — the existing Python code in this repo (e.g., plugins/elegance-pipeline/elegance_pipeline/pipeline.py, plugins/hookify/hookify/core/) uses standard Python 3.9+ features. This minimum version would unnecessarily prevent running on Python 3.12/3.13 which are the current stable releases. Consider either removing this file from this PR (it's unrelated to code-simplifier) or lowering to >=3.10 or >=3.12 to match what the existing code actually requires.
| --- | ||
| name: code-simplifier | ||
| description: Simplifies recently modified code using qyl engineering principles. Measures elegance as problem-complexity / solution-complexity. Language-agnostic — reads CLAUDE.md for project standards. | ||
| model: opus |
There was a problem hiding this comment.
The agent frontmatter is missing the tools: field. Every other agent in this repo declares which tools it can use (e.g., plugins/council/agents/opus-captain.md declares Task, Read, WebSearch, WebFetch, Bash; plugins/elegance-pipeline/agents/elegance-implementer.md declares Read, Write, Edit, Grep, Glob, Bash). This agent's workflow requires reading files (step 1 and 2), running git diff (step 2), and editing code (step 4), so it should declare the appropriate tools (at minimum Read, Grep, Glob, Bash, Write, Edit).
| model: opus | |
| model: opus | |
| tools: [Read, Grep, Glob, Bash, Write, Edit] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d796f59df6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## Usage | ||
|
|
||
| The agent activates when the skill `simplify` is invoked. It reads the project's CLAUDE.md, identifies recent changes, scores elegance, and simplifies candidates. |
There was a problem hiding this comment.
simplify entrypoint
This usage line tells users to invoke a simplify skill, but this commit only adds an agent and the plugin manifest has no skills registration (plugins/code-simplifier/.claude-plugin/plugin.json only lists agents). In practice, users following the README will look for a non-existent skill/command and the new plugin appears broken; either add the skill/command entrypoint or update the usage text to the actual invocation path.
Useful? React with 👍 / 👎.
What
Adds
code-simplifierplugin tuned to qyl engineering principles. Replaces Anthropic's JS/React-centric code-simplifier with a language-agnostic version.Key differences from Anthropic's code-simplifier
Changes
plugins/code-simplifier/(plugin.json + 1 Opus agent + README)marketplace.json(11 → 12 plugins, 24 → 25 agents)CHANGELOG.mdcode-simplifier@claude-plugins-officialuninstalled locally