fix: add missing content paths to plugin.json files #50
Conversation
- autonomous-ci: add skills path - code-review: add skills path - ancplua-docs-librarian: add skills and agents paths Fixes plugins not appearing in Claude Code plugin manager. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughThree plugin manifest files receive additions of new configuration properties: "skills" field is added to all three, and an "agents" field is added to one. These changes extend metadata in the plugin configurations without modifying existing properties or behavior. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Summary of ChangesHello @ANcpLua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical visibility problem within the Claude Code plugin manager by updating several Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of plugins not appearing in the Claude Code plugin manager by adding the necessary skills and agents content paths to the respective plugin.json files. The changes correctly declare the locations of these components, ensuring proper plugin discovery and functionality. This is a good and necessary fix that aligns with the implicit schema requirements for plugin configuration.
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical discoverability issue where 4 out of 6 plugins were not appearing in the Claude Code plugin manager. The fix adds the missing skills and agents path declarations to the plugin.json manifest files, ensuring all plugins properly advertise their content.
Key changes:
- Added
skillspath declaration toautonomous-ciandcode-reviewplugins - Added both
skillsandagentspaths toancplua-docs-librarianplugin
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
plugins/autonomous-ci/.claude-plugin/plugin.json |
Added skills path declaration pointing to ./skills directory containing the autonomous-ci skill |
plugins/code-review/.claude-plugin/plugin.json |
Added skills path declaration pointing to ./skills directory containing the code-review skill |
plugins/ancplua-docs-librarian/.claude-plugin/plugin.json |
Added skills path and agents array declaration pointing to the librarian agent and skills directory |
Review Summary: ✅ No issues found. All changes are correct and complete:
- JSON syntax is valid (proper comma placement)
- All declared paths exist and contain the expected content (SKILL.md files and agent definitions)
- The changes align with the plugin manifest schema as defined in the repository guidelines
- The other 3 plugins (dotnet-architecture-lint, metacognitive-guard, otelwiki) already have their content paths correctly declared
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review (Opus 4.5)
Verdict: ✅ APPROVED
Summary
Adds missing skills and agents content path declarations to three plugin.json files (ancplua-docs-librarian, autonomous-ci, code-review), enabling them to appear correctly in Claude Code's plugin manager.
Findings
Validation Checks:
| Check | Status |
|---|---|
| JSON syntax | ✅ Valid |
| Referenced paths exist | ✅ All verified |
| Plugin schema | ✅ Complete |
| Type T violations | ✅ None (pure Type A config) |
| Security | ✅ No secrets exposed |
Minor Observation (non-blocking):
- CHANGELOG.md doesn't have a dedicated entry for this specific fix. Consider adding one.
Strengths
- Correct diagnosis of the root cause (missing content paths)
- Minimal, focused changes - only what's necessary
- All referenced paths verified to exist in the filesystem
- Follows existing plugin.json patterns from other plugins
Autonomous review by Claude Opus 4.5 (Type A repo)
Summary
skillspath to autonomous-ci plugin.jsonskillspath to code-review plugin.jsonskillsandagentspaths to ancplua-docs-librarian plugin.jsonProblem
Only 2 of 6 plugins were showing in Claude Code plugin manager because the plugin.json files were missing declarations for their content (skills, agents).
Test plan
/pluginin Claude Code🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.