ss-tproxy: revamp postinst and spec #12893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenx97
force-pushed
the
ss-tproxy-postinst-refresh
branch
2 times, most recently
from
001fb30 to
a6c70f5
Compare
|
fix pending: try-restart is a no-op when the unit is not active. |
chenx97
force-pushed
the
ss-tproxy-postinst-refresh
branch
from
a6c70f5 to
a39c923
Compare
- remove prerm - no need to stop the oneshot unit before the upgrade - restart active units in postinst instead - also attempt to start enabled but inactive units - use git-based SRCS[^1] - make echoes more informative - reload the systemd configuration in postinst - use `is-active` in a more elegant manner - with `--quiet` we just need to know if systemctl returns 0 - silence systemd unit start failures in postinst as we should allow users to debug their own configurations later [^1]: https://github.blog/open-source/git/update-on-the-future-stability-of-source-code-archives-and-hashes/#future-stability-of-archives-and-hashes
chenx97
force-pushed
the
ss-tproxy-postinst-refresh
branch
from
a39c923 to
768de84
Compare
Upgrading works 
Reinstalling with disabled and inactive unit works 
Reinstalling with active unit works 
Reinstalling with enabled but inactive unit works 
Installation doesn't fail when the systemd unit fails |
MingcongBai
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic Description
own configurations later
[^1]: https://github.blog/open-source/git/update-on-the-future-stability-of-source-code-archives-and-hashes/#future-stability-of-archives-and-hashes
Package(s) Affected
Security Update?
No
Build Order
Test Build(s) Done
Primary Architectures
noarch