Skip to content

Fix profile edit form UX and remove duplicate save action #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssid18 wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −24
Open

Fix profile edit form UX and remove duplicate save action #217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46f21d0
Fix profile edit form UX and remove duplicate save action
ssid18 Jan 6, 2026
8e1e206
Hide Edit Profile button during edit mode
ssid18 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 17 additions & 24 deletions frontend/src/components/pages/ProfilePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,24 +30,17 @@ const ProfilePage = () => {
>
<div className="flex items-center justify-between mb-8">
<h1 className="text-3xl font-bold">Profile</h1>
<motion.button
whileHover={{ scale: 1.05 }}
whileTap={{ scale: 0.95 }}
onClick={() => setIsEditing(!isEditing)}
className="px-4 py-2 bg-green-500 hover:bg-green-600 rounded-lg transition-colors flex items-center"
>
{isEditing ? (
<>
<Save size={18} className="mr-2" />
Save Changes
</>
) : (
<>
<Edit size={18} className="mr-2" />
Edit Profile
</>
)}
</motion.button>
{!isEditing && (
<motion.button
whileHover={{ scale: 1.05 }}
whileTap={{ scale: 0.95 }}
onClick={() => setIsEditing(true)}
className="px-4 py-2 bg-green-500 hover:bg-green-600 rounded-lg transition-colors flex items-center"
>
<Edit size={18} className="mr-2" />
Edit Profile
</motion.button>
)}
</div>

<div className="bg-gray-900 rounded-xl border border-gray-800 overflow-hidden">
Expand Down Expand Up @@ -90,7 +83,7 @@ const ProfilePage = () => {
value={profile.name}
onChange={(e) => setProfile({ ...profile, name: e.target.value })}
disabled={!isEditing}
className="bg-transparent text-white focus:outline-none disabled:opacity-50"
className="bg-gray-800 rounded-md px-3 py-2 text-white focus:outline-none focus:ring-2 focus:ring-green-500 disabled:opacity-50"
/>
</div>
</div>
Expand All @@ -104,7 +97,7 @@ const ProfilePage = () => {
value={profile.email}
onChange={(e) => setProfile({ ...profile, email: e.target.value })}
disabled={!isEditing}
className="bg-transparent text-white focus:outline-none disabled:opacity-50"
className="bg-gray-800 rounded-md px-3 py-2 text-white focus:outline-none focus:ring-2 focus:ring-green-500 disabled:opacity-50"
/>
</div>
</div>
Expand All @@ -118,7 +111,7 @@ const ProfilePage = () => {
value={profile.company}
onChange={(e) => setProfile({ ...profile, company: e.target.value })}
disabled={!isEditing}
className="bg-transparent text-white focus:outline-none disabled:opacity-50"
className="bg-gray-800 rounded-md px-3 py-2 text-white focus:outline-none focus:ring-2 focus:ring-green-500 disabled:opacity-50"
/>
</div>
</div>
Expand All @@ -134,7 +127,7 @@ const ProfilePage = () => {
value={profile.website}
onChange={(e) => setProfile({ ...profile, website: e.target.value })}
disabled={!isEditing}
className="bg-transparent text-white focus:outline-none disabled:opacity-50"
className="bg-gray-800 rounded-md px-3 py-2 text-white focus:outline-none focus:ring-2 focus:ring-green-500 disabled:opacity-50"
/>
</div>
</div>
Expand All @@ -148,7 +141,7 @@ const ProfilePage = () => {
value={profile.github}
onChange={(e) => setProfile({ ...profile, github: e.target.value })}
disabled={!isEditing}
className="bg-transparent text-white focus:outline-none disabled:opacity-50"
className="bg-gray-800 rounded-md px-3 py-2 text-white focus:outline-none focus:ring-2 focus:ring-green-500 disabled:opacity-50"
/>
</div>
</div>
Expand All @@ -162,7 +155,7 @@ const ProfilePage = () => {
value={profile.twitter}
onChange={(e) => setProfile({ ...profile, twitter: e.target.value })}
disabled={!isEditing}
className="bg-transparent text-white focus:outline-none disabled:opacity-50"
className="bg-gray-800 rounded-md px-3 py-2 text-white focus:outline-none focus:ring-2 focus:ring-green-500 disabled:opacity-50"
/>
</div>
</div>
Expand Down