Skip to content

ui: move auth switch links into authentication card #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kalpana-chavhan wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −34
Open

ui: move auth switch links into authentication card #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Frontend/env-example
View file
Open in desktop

This file was deleted.

29 changes: 15 additions & 14 deletions Frontend/src/pages/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,11 @@ export default function LoginPage() {
console.log("Google login error", error);
return;
}

// AuthContext will handle navigation based on user onboarding status and role
};

return (
<div className="min-h-screen flex flex-col bg-gradient-to-br from-purple-50 to-indigo-50 dark:from-gray-900 dark:to-gray-800">
{/* Header - Now simplified with only the Logo */}
<div className="flex justify-between items-center p-6">
<Link
to="/"
Expand All @@ -64,17 +63,6 @@ export default function LoginPage() {
Inpact
</span>
</Link>
<div className="flex space-x-4">
<span className="text-sm text-gray-600 dark:text-gray-300">
Don't have an account?
</span>
<Link
to="/signup"
className="text-sm font-medium text-purple-600 hover:text-purple-800 dark:text-purple-400 dark:hover:text-purple-300 transition-colors duration-200"
>
Sign up
</Link>
</div>
</div>

<div className="flex-1 flex items-center justify-center p-6">
Expand Down Expand Up @@ -230,6 +218,19 @@ export default function LoginPage() {
Facebook
</button>
</div>

{/* --- MOVED AUTH SWITCH LINK --- */}
<div className="mt-8 pt-6 border-t border-gray-100 dark:border-gray-700 text-center">
<p className="text-sm text-gray-600 dark:text-gray-300">
Don't have an account?{" "}
<Link
to="/signup"
className="font-medium text-purple-600 hover:text-purple-800 dark:text-purple-400 dark:hover:text-purple-300 transition-colors duration-200"
>
Sign up
</Link>
</p>
</div>
</div>
</div>
</div>
Expand All @@ -241,4 +242,4 @@ export default function LoginPage() {
</footer>
</div>
);
}
}
32 changes: 15 additions & 17 deletions Frontend/src/pages/Signup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

import { useState } from "react";
import { Link, useNavigate } from "react-router-dom";
import { Check, Eye, EyeOff, Rocket } from "lucide-react";
Expand Down Expand Up @@ -42,7 +41,6 @@ export default function SignupPage() {
try {
const { name, email, password } = formData;

// Check if user already exists
const { data: existingUser } = await supabase.auth.signInWithPassword({
email,
password: "dummy-password-to-check-existence",
Expand All @@ -69,7 +67,6 @@ export default function SignupPage() {
return;
}
setIsLoading(false);
// AuthContext will handle navigation based on user onboarding status and role
} catch (err) {
setError("Something went wrong. Please try again.");
} finally {
Expand All @@ -86,8 +83,6 @@ export default function SignupPage() {
console.log("Google login error", error);
return;
}

// AuthContext will handle navigation based on user onboarding status and role
};

const passwordStrength = () => {
Expand Down Expand Up @@ -119,6 +114,7 @@ export default function SignupPage() {

return (
<div className="min-h-screen flex flex-col bg-gradient-to-br from-purple-50 to-indigo-50 dark:from-gray-900 dark:to-gray-800">
{/* Header - Simplified */}
<div className="flex justify-between items-center p-6">
<Link
to="/"
Expand All @@ -129,17 +125,6 @@ export default function SignupPage() {
Inpact
</span>
</Link>
<div className="flex space-x-4">
<span className="text-sm text-gray-600 dark:text-gray-300">
Already have an account?
</span>
<Link
to="/login"
className="text-sm font-medium text-purple-600 hover:text-purple-800 dark:text-purple-400 dark:hover:text-purple-300 transition-colors duration-200"
>
Sign in
</Link>
</div>
</div>

<div className="flex-1 flex items-center justify-center p-6">
Expand Down Expand Up @@ -221,6 +206,19 @@ export default function SignupPage() {
</div>
</div>
)}

{/* --- MOVED AUTH SWITCH LINK --- */}
<div className="mt-8 pt-6 border-t border-gray-100 dark:border-gray-700 text-center">
<p className="text-sm text-gray-600 dark:text-gray-300">
Already have an account?{" "}
<Link
to="/login"
className="font-medium text-purple-600 hover:text-purple-800 dark:text-purple-400 dark:hover:text-purple-300 transition-colors duration-200"
>
Sign in
</Link>
</p>
</div>
</div>
</div>
</div>
Expand All @@ -231,4 +229,4 @@ export default function SignupPage() {
</footer>
</div>
);
}
}