Skip to content

Conversation

@Himani78116
Copy link

@Himani78116 Himani78116 commented Jan 9, 2026

Fixes #941

Problem:
When the window was maximized, two vertical scrollbars appeared, causing confusing UX and layout overflow.

Cause:
The issue was caused by nested containers applying "overflow-y-auto" simultaneously, resulting in multiple scroll contexts.

Solution:
Removed redundant overflow handling and ensured a single scroll container at the layout level.

Result:
Scroll behavior is now consistent across window sizes with a single scrollbar.

Before:
https://github.com/user-attachments/assets/44a31e0d-a618-48b0-a634-9f798818b9cc

After:
https://github.com/user-attachments/assets/328601f9-d69a-438e-ae3a-035d3047ea4e

I've included before and after recordings to clearly demonstrate the issue and the fix. Please let me know if you'd like the solution
handled differently or split further.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

⚠️ No issue was linked in the PR description.
Please make sure to link an issue (e.g., 'Fixes #issue_number')

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2026

📝 Walkthrough

Walkthrough

The layout component's inner container had the overflow-y-auto CSS class removed, changing its vertical scroll behavior from auto-scrolling to default scrolling behavior.

Changes

Cohort / File(s) Summary
Scroll behavior adjustment
frontend/src/layout/layout.tsx
Removed overflow-y-auto class from inner layout div, modifying the vertical scroll handling for the content area

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A scroll bar once had auto delight,
But now rests gently, smooth and light,
One class removed from Tailwind's song,
The layout flows calm, not forced along. 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fixed double scroll-bar issue' directly addresses the main change - removing overflow-y-auto styling to eliminate duplicate scrollbars.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

⚠️ No issue was linked in the PR description.
Please make sure to link an issue (e.g., 'Fixes #issue_number')

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

⚠️ No issue was linked in the PR description.
Please make sure to link an issue (e.g., 'Fixes #issue_number')

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

⚠️ No issue was linked in the PR description.
Please make sure to link an issue (e.g., 'Fixes #issue_number')

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

⚠️ No issue was linked in the PR description.
Please make sure to link an issue (e.g., 'Fixes #issue_number')

@skyforge-glitch
Copy link

@Himani78116 Thanks for the suggestions! I’ve updated the PR #941 accordingly and cleaned it up based on the feedback.
The issue is currently assigned to me, so I’ll be handling the fix here, any parallel PRs for the same issue can be closed to avoid duplication. Appreciate the review.

@skyforge-glitch
Copy link

@Himani78116 Thanks for the suggestions! I’ve updated the PR #941 accordingly and cleaned it up based on the feedback. The issue is currently assigned to me, so I’ll be handling the fix here, any parallel PRs for the same issue can be closed to avoid duplication. Appreciate the review.

The minimal one-line change was sufficient here. I initially over-scoped the fix while exploring the codepath.

@Himani78116
Copy link
Author

@Himani78116 Thanks for the suggestions! I’ve updated the PR #941 accordingly and cleaned it up based on the feedback. The issue is currently assigned to me, so I’ll be handling the fix here, any parallel PRs for the same issue can be closed to avoid duplication. Appreciate the review.

Thanks for the clarification. Since the issue is already assigned to you, I'll step back on this to avoid duplication. Appreciate the review and guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants