Skip to content

Conversation

@uju09
Copy link
Contributor

@uju09 uju09 commented Nov 22, 2025

Description

This PR removes unused dummy/mock data and outdated asset files that were previously used for testing UI functionality but are no longer referenced anywhere in the codebase.
Cleaning these unnecessary files improves maintainability, reduces project size, and aligns the app with current production assets.

Fixes #555


Type of change

  • Refactor (does not change functionality, e.g. cleanup of unused assets)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Verified unused assets using a custom Dart script scanning the entire lib/ directory.
  • Cross-checked with global search in VS Code to confirm no references to removed assets.
  • Built the application locally to ensure no missing asset errors or warnings were introduced.
  • Confirmed that the app runs as expected after removal.

No functional behavior was changed.


Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (asset cleanup)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@coderabbitai
Copy link

coderabbitai bot commented Nov 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

🎉 Welcome @uju09!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@uju09 uju09 changed the base branch from master to dev November 22, 2025 17:53
@uju09
Copy link
Contributor Author

uju09 commented Nov 22, 2025

@M4dhav I used script to check the dummy data, but the tests are failing as they are searching for mocks.

@uju09
Copy link
Contributor Author

uju09 commented Nov 23, 2025

@coderabbitai Review

@coderabbitai
Copy link

coderabbitai bot commented Nov 23, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link

coderabbitai bot commented Nov 23, 2025

@uju09: I'll review the changes in this PR. I'll pay special attention to the failing tests you mentioned that are looking for the removed mocks - this will need to be addressed to ensure the tests pass after the cleanup.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@M4dhav M4dhav self-requested a review November 23, 2025 13:25
@M4dhav M4dhav added enhancement New feature or request good first issue Good for newcomers labels Nov 23, 2025
@M4dhav
Copy link
Contributor

M4dhav commented Nov 23, 2025

@M4dhav I used script to check the dummy data, but the tests are failing as they are searching for mocks.

Could you please elaborate on this

@uju09
Copy link
Contributor Author

uju09 commented Nov 23, 2025

@M4dhav I used a dart script to find unused assets and deleted them, but the run test is failing.

@uju09
Copy link
Contributor Author

uju09 commented Nov 23, 2025

@M4dhav This are the unused assets that have been deleted.

Screenshot 2025-11-23 at 7 07 10 PM

@M4dhav
Copy link
Contributor

M4dhav commented Nov 23, 2025

I would recommend going through the files manually, as there is dummy data except assets

@uju09
Copy link
Contributor Author

uju09 commented Nov 23, 2025

@M4dhav Ok, I will go through files manually, but it will take sometime as my End Sems are going on.

@rahul-vyas-dev
Copy link

is this issue still open??

@M4dhav
Copy link
Contributor

M4dhav commented Dec 9, 2025

is this issue still open??

this is a PR, you can check #555 for the issue

Copy link
Contributor

@M4dhav M4dhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated tests are still failing

@uju09
Copy link
Contributor Author

uju09 commented Dec 26, 2025

@M4dhav I will work on this PR in two working days.

@uju09
Copy link
Contributor Author

uju09 commented Jan 5, 2026

@M4dhav I have delete the mock data, if u want any changes, let me know.

@uju09 uju09 requested a review from M4dhav January 5, 2026 15:47
@uju09
Copy link
Contributor Author

uju09 commented Jan 18, 2026

@M4dhav I request you to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Dummy data in places across Resonate

3 participants