Skip to content

Fix Quick Match cancel button not responding #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rozerxshashank wants to merge 3 commits into
base: dev
Choose a base branch
from
+18 −9
Open

Fix Quick Match cancel button not responding #673

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e94b21
Fix cancel button not responding during quick match
Rozerxshashank Dec 18, 2025
1a3b9ce
Resolve merge conflict and fix cancel request flow
Rozerxshashank Dec 19, 2025
8e3b730
Fixed Bug of databases.deleteDocument
Rozerxshashank Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions lib/controllers/pair_chat_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,17 +238,26 @@ class PairChatController extends GetxController {
Get.toNamed(AppRoutes.pairChat);
}

Future<void> cancelRequest() async {
await tablesDB.deleteRow(
databaseId: masterDatabaseId,
tableId: pairRequestTableId,
rowId: requestDocId!,
);
subscription?.close();
userAddedSubscription?.close();
Future<void> cancelRequest() async {
try {
if (requestDocId != null) {
await tablesDB.deleteRow(
databaseId: masterDatabaseId,
tableId: pairRequestTableId,
rowId: requestDocId!,
);
}

requestDocId = null;
Copy link
Contributor

@M4dhav M4dhav Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why set the requestDocId to null?

Copy link
Author

@Rozerxshashank Rozerxshashank Jan 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set to null beacuse if app keeps the old requestDocId it may try to cancel the same request again. (Like when button tapped twice)
It just avoids accidental reuse of an invalid ID and reset the controlller to a complete clean state.


await subscription?.close();
await userAddedSubscription?.close();
} catch (e) {
log('Cancel request failed: $e');
} finally {
Get.offNamedUntil(AppRoutes.tabview, (route) => false);
}

}
void toggleMic() async {
isMicOn.value = !isMicOn.value;
await Get.find<LiveKitController>().liveKitRoom.localParticipant
Expand Down