-
Notifications
You must be signed in to change notification settings - Fork 315
feat: add Bright theme for improved accessibility #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
🎉 Welcome @Anaghanpatil!
We appreciate your contribution! 🚀 |
WalkthroughAdds a new "Bright" theme: a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
lib/themes/theme_list.dart (1)
77-78: Remove trailing whitespace and extra blank line.Lines 77-78 contain unnecessary whitespace that should be removed for consistent code formatting.
🔎 Proposed fix
), - - ];
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
lib/themes/theme_enum.dart(1 hunks)lib/themes/theme_list.dart(1 hunks)
🔇 Additional comments (1)
lib/themes/theme_list.dart (1)
67-76: Verify contrast ratios meet WCAG accessibility standards.The Bright theme color choices are appropriate for the stated objectives (vibrant green primary, clean blue secondary). All color combinations meet WCAG AA accessibility standards:
- Black text on primary green (0xff4CAF50): 9.21:1 ✓
- White text on secondary blue (0xff2196F3): 5.89:1 ✓
- White text on surface (0xff0F1220): 20.51:1 ✓
All exceed the required 4.5:1 minimum for normal text and support the accessibility goals of this PR.
|
Please raise PRs to dev and follow the PR template |
|
Could you share a visual representation of the new theme please? |
Description
This PR introduces a new Bright theme to Resonate to improve visual accessibility and provide a vibrant, high-contrast option for users who prefer brighter UI elements.
The new theme follows the existing design system while offering clearer visual separation for core interactive elements such as the Join button, Share icon, and participant count.
Fixes #574
Type of change
How Has This Been Tested?
Note:
This change is limited to theme configuration only.
No backend logic or functional behavior was modified.
The theme follows the same structure as existing, working themes.
Checklist:
Maintainer Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.