-
Notifications
You must be signed in to change notification settings - Fork 315
Improve Marathi translations for natural language and clarity #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improve Marathi translations for natural language and clarity #691
Conversation
📝 WalkthroughWalkthroughThis PR updates Marathi localization Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🎉 Welcome @kumbharkajal!
We appreciate your contribution! 🚀 |
|
The UTF-8 decoding error is fixed by re-saving app_mr.arb as plain UTF-8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @lib/l10n/app_mr.arb:
- Line 47: Replace the systematic misspelling "आपणण" with the correct Marathi
"आपण" throughout the ARB file; update every affected localization value (e.g.,
the keys "youNoStories", "youNoLikedStories", "you", "areYouSure", "loggingOut"
and all other occurrences listed in the review) by performing a global
search-and-replace for "आपणण" → "आपण" so all message strings are corrected
consistently.
- Line 39: The Marathi localization contains a systematic typo where "आपणल्या"
and "आपणले" are used instead of the correct possessive "आपल्या"; update all
affected message values to use "आपल्या" (or the correct contextual possessive) —
e.g., replace "आपणल्या" → "आपल्या" and "आपणले" → "आपल्या" in the entries such as
"yourStories", "yourLikedStories", "emailChangeInfo", and
"oauthUsersEmailChangeInfo" and perform a file-wide search for other instances
(lines noted in the review) to apply the same fix consistently.
🧹 Nitpick comments (1)
lib/l10n/app_mr.arb (1)
293-293: Consider: Consistency in "add" vs "join" translationsThe phrase "सामील व्हा" (join/become part of) is used for multiple "add" actions:
- Line 293: "addModerator" → "मॉडरेटर सामील व्हा"
- Line 297: "addSpeaker" → "स्पीकर सामील व्हा"
- Line 1113: "addChapter" → "अध्याय सामील व्हा"
- Line 1485: "addFriend" → "मित्र सामील व्हा"
While "सामील व्हा" works conversationally, you might want to consider using "जोडा" (add) for actions where the user is adding something (like chapters) versus joining something (like communities at line 605 where "सामील व्हा" is more appropriate).
However, if the current phrasing aligns with natural Marathi usage in your target audience, this is acceptable.
Also applies to: 297-297, 605-605, 1113-1113, 1485-1485
This PR improves Marathi translations in
lib/l10n/app_mr.arbto make themmore natural, fluent, and linguistically correct.
✔ Replaced literal / Hindi-influenced translations with proper Marathi
✔ Improved clarity and consistency of UI labels and messages
✔ Updated descriptions where required
✔ Only localization content was changed (no code or lock files)
Please let me know if any wording needs further refinement.
Fixed the CI failure by re-saving app_mr.arb as plain UTF-8.
The previous error was due to invalid file encoding on Windows.
CI should now pass.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.