feat: Add centralized ErrorService for consistent error handling by TenFinges · Pull Request #723 · AOSSIE-Org/Resonate

TenFinges · 2026-01-15T15:18:45Z

Description

Added a centralized ErrorService to handle errors consistently across the app. This replaces scattered error handling with a unified approach that provides user-friendly messages, accessibility support, and centralized logging.

Key changes:

New ErrorService class with handle() and handleSilently() methods
New ErrorType enum for categorizing errors (network, auth, storage, database, validation, general)
Added 13 new localization strings for error messages
Updated AuthenticationController, RoomsController, and CreateRoomController as pilot implementations

Fixes #722

Type of change

New feature (non-breaking change which adds functionality)
Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

Added 14 unit tests for ErrorService covering:
- User-friendly message generation for all error types
- Appwrite-specific error handling (invalid credentials, user not found, etc.)
- Silent error handling

flutter test test/services/error_service_test.dart
# 00:02 +14: All tests passed!

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have checked my code and corrected any misspellings

Maintainer Checklist

closes Add centralized error handling service #722
Tag the PR with the appropriate labels

coderabbitai · 2026-01-15T15:18:53Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-15T15:18:54Z

🎉 Welcome @TenFinges!
Thank you for your pull request! Our team will review it soon. 🔍

Please ensure your PR follows the contribution guidelines. ✅
All automated tests should pass before merging. 🔄
If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

TenFinges · 2026-01-15T15:27:34Z

Please note that I've added the new error strings in English only. Previous contributors (or any native speakers) could contribute translations for Bengali, Hindi, Gujarati, Kannada, Marathi, and Punjabi.

M4dhav

Please fix merge conflicts

lib/services/error_service.dart

M4dhav · 2026-02-11T10:20:18Z

lib/services/error_service.dart

+  /// Categorizes an error into an [ErrorType] based on its type and message.
+  static ErrorType _categorizeError(dynamic error) {
+    if (error is AppwriteException) {
+      return _categorizeAppwriteError(error);
+    }
+
+    final errorString = error.toString().toLowerCase();
+
+    if (errorString.contains('network') ||
+        errorString.contains('socket') ||
+        errorString.contains('connection') ||
+        errorString.contains('timeout')) {
+      return ErrorType.network;
+    }
+
+    if (errorString.contains('auth') ||
+        errorString.contains('credential') ||
+        errorString.contains('password') ||
+        errorString.contains('login')) {
+      return ErrorType.authentication;
+    }
+
+    if (errorString.contains('storage') ||
+        errorString.contains('file') ||
+        errorString.contains('upload')) {
+      return ErrorType.storage;
+    }
+
+    return ErrorType.general;


While this does seem logical enough, could you please share examples of In App Errors and how they would be segregated?

Here are a few examples of how errors are categorized:

Network (ErrorType.network): When a user's device loses connectivity while joining a room (rooms_controller.dart:joinRoom), the Appwrite SDK throws a SocketException: Connection refused — matches socket and connection. When a LiveKit WebSocket connection drops during pair chat (livekit_controller.dart), we get a TimeoutException — matches timeout.

Authentication (ErrorType.authentication): When Google/GitHub OAuth fails in authentication_controller.dart:loginWithGoogle(), the error message typically contains auth — categorized as authentication. Also happens when a session expires mid-use and account.get() fails with an auth error.

Storage (ErrorType.storage): When a profile image upload fails in edit_profile_controller.dart:saveProfile() via storage.createFile(), any non-Appwrite error containing file or upload in its message (e.g., FileSystemException).

General (ErrorType.general): Fallback for things like a FormatException when parsing room data in rooms_controller.dart (doesn't match any keyword), or a RangeError / unexpected runtime exception.

I removed ErrorType.database and ErrorType.validation from _categorizeError. In our app, database and validation errors originate strictly from Appwrite (document_not_found, general_argument_invalid, etc.) and are properly handled by _categorizeAppwriteError via structured type/code fields. Non-Appwrite Dart exceptions don't produce database or validation errors in our current codebase, so they correctly fall through to ErrorType.general.

lib/services/error_service.dart

M4dhav · 2026-02-11T10:23:38Z

lib/services/error_service.dart

+  static ErrorType _categorizeAppwriteError(AppwriteException error) {
+    final type = error.type ?? '';
+    final code = error.code ?? 0;
+
+    // Authentication errors
+    if (type.contains('user_') ||
+        type.contains('session_') ||
+        code == 401 ||
+        code == 403) {
+      return ErrorType.authentication;
+    }
+
+    // Database/document errors
+    if (type.contains('document_') || type.contains('database_')) {
+      return ErrorType.database;
+    }
+
+    // Storage errors
+    if (type.contains('storage_') || type.contains('file_')) {
+      return ErrorType.storage;
+    }
+
+    // Validation errors


Same for this, please share examples of specific errors and how they would be segregated here

Authentication (ErrorType.authentication):

Login with wrong password (authentication_controller.dart:login): type: 'user_invalid_credentials', code: 401 — matches type.contains('user_').

Expired session when fetching rooms or profile: type: 'user_session_not_found', code: 401 — matches type.contains('session_') and code == 401.

Unauthorized access to another user's data: code: 403 — matches code == 403.

Database (ErrorType.database):

Fetching a deleted room in rooms_controller.dart:getRoomById(): type: 'document_not_found', code: 404 — matches type.contains('document_').

Deleting an already-ended pair chat in pair_chat_controller.dart:endChat() (already handled explicitly there for document_not_found): matches type.contains('document_').

Database query fails when loading user list: type: 'database_not_found' — matches type.contains('database_').

Storage (ErrorType.storage):

Profile image upload fails in edit_profile_controller.dart:saveProfile() via storage.createFile(): type: 'storage_file_type_unsupported' — matches type.contains('storage_').

Deleting a nonexistent profile image via storage.deleteFile(): type: 'file_not_found' — matches type.contains('file_').

Validation (ErrorType.validation):

Short password during login/signup (authentication_controller.dart): type: 'general_argument_invalid', code: 400 — matches both the type check and code == 400.

Invalid email format during change_email_controller.dart:changeEmailInAuth(): same type.

Network (ErrorType.network):

Device is offline: Appwrite SDK returns code: 0 — matches code == 0.

Appwrite server down: code: 503 or code: 504 — matches those code checks.

TenFinges requested a review from M4dhav as a code owner January 15, 2026 15:18

M4dhav assigned TenFinges Jan 24, 2026

M4dhav added the enhancement New feature or request label Jan 24, 2026

M4dhav linked an issue Jan 24, 2026 that may be closed by this pull request

Add centralized error handling service #722

Open

M4dhav requested changes Jan 24, 2026

View reviewed changes

TenFinges force-pushed the feature/centralized-error-handling branch from 776ff7f to c6e2639 Compare January 24, 2026 18:17

feat: Add centralized ErrorService for consistent error handling

78904fc

TenFinges force-pushed the feature/centralized-error-handling branch from c6e2639 to 78904fc Compare January 24, 2026 18:19

TenFinges requested a review from M4dhav January 24, 2026 18:26

M4dhav requested changes Feb 11, 2026

View reviewed changes

TenFinges added 2 commits March 1, 2026 13:40

refactor: clean up error_service, remove dead code and redundancy

fbc002a

fix: resolve null safety errors in error_service

3538765

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add centralized ErrorService for consistent error handling#723

feat: Add centralized ErrorService for consistent error handling#723
TenFinges wants to merge 3 commits intoAOSSIE-Org:devfrom
TenFinges:feature/centralized-error-handling

TenFinges commented Jan 15, 2026

Uh oh!

coderabbitai bot commented Jan 15, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

TenFinges commented Jan 15, 2026

Uh oh!

M4dhav left a comment

Uh oh!

Uh oh!

Uh oh!

M4dhav Feb 11, 2026

Uh oh!

TenFinges Mar 1, 2026

Uh oh!

Uh oh!

M4dhav Feb 11, 2026

Uh oh!

TenFinges Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

TenFinges commented Jan 15, 2026

Description

Type of change

How Has This Been Tested?

Checklist:

Maintainer Checklist

Uh oh!

coderabbitai bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

TenFinges commented Jan 15, 2026

Uh oh!

M4dhav left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

M4dhav Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

TenFinges Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

M4dhav Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

TenFinges Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jan 15, 2026 •

edited

Loading