added 15 missing Marathi strings#737
added 15 missing Marathi strings#737PranjaliBhardwaj wants to merge 1 commit intoAOSSIE-Org:masterfrom
Conversation
Signed-off-by: Pranjali Bhardwaj <pranjalisharma6543@gmail.com>
|
🎉 Welcome @PranjaliBhardwaj!
We appreciate your contribution! 🚀 |
📝 WalkthroughWalkthroughThis PR adds 16 new localization keys to the Marathi language file (app_mr.arb), covering search functionality, room management, and message deletion features. Each key includes both the translation string and metadata description entries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
lib/l10n/app_mr.arb (1)
1761-1768: Fix inconsistent indentation for the new entries.Lines 1762-1768 have inconsistent indentation compared to the rest of the file, which uses 4-space indentation. This affects code maintainability and style consistency.
Suggested fix
"deleteMessageTitle": "संदेश हटवा", -"@deleteMessageTitle": { - "description": "Delete message पुष्टी संवादात शीर्षक दाखवले जाते." -}, -"deleteMessageContent": "आपण खरोखर हा संदेश हटवू इच्छिता का?", -"@deleteMessageContent": { - "description": "वापरकर्त्याला विचारले जाणारे पुष्टीकरण मजकूर की तो संदेश हटवू इच्छितो का." -} + "@deleteMessageTitle": { + "description": "Delete message पुष्टी संवादात शीर्षक दाखवले जाते." + }, + "deleteMessageContent": "आपण खरोखर हा संदेश हटवू इच्छिता का?", + "@deleteMessageContent": { + "description": "वापरकर्त्याला विचारले जाणारे पुष्टीकरण मजकूर की तो संदेश हटवू इच्छितो का." + }
🤖 Fix all issues with AI agents
In `@lib/l10n/app_mr.arb`:
- Around line 1343-1346: The "hide" localization entry currently uses the
Marathi string "काढून टाका" (meaning "remove") which duplicates the "remove"
key; update the "hide" key's value to "लपवा" and keep or adjust the accompanying
"@hide.description" if needed to ensure it reads as "button text to hide an
item" consistent with existing keys like "hidePassword" (use "लपवा" for the
value so semantics match the intended hide action).
🧹 Nitpick comments (1)
lib/l10n/app_mr.arb (1)
951-958: Duplicate translations forsearchFailedandsearchRoomsError.Both keys have identical Marathi translations: "कोठे शोधणे अयोग्य. कृपया पुन्हा प्रयत्न करा." Consider whether these should have differentiated messages based on their distinct descriptions, or if one key is redundant.
| "hide": "काढून टाका", | ||
| "@hide": { | ||
| "description": "दृश्यातून आयटम काढून टाकण्यासाठी बटण मजकूर." | ||
| }, |
There was a problem hiding this comment.
Translation for hide should be "लपवा" not "काढून टाका".
The key hide is translated as "काढून टाका" which means "remove" - the same as the existing remove key at line 1339. This creates semantic ambiguity. The file already uses "लपवा" for hiding actions (see hidePassword at line 11: "पासवर्ड लपवा").
Suggested fix
- "hide": "काढून टाका",
+ "hide": "लपवा",
"@hide": {
- "description": "दृश्यातून आयटम काढून टाकण्यासाठी बटण मजकूर."
+ "description": "दृश्यातून आयटम लपवण्यासाठी बटण मजकूर."
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "hide": "काढून टाका", | |
| "@hide": { | |
| "description": "दृश्यातून आयटम काढून टाकण्यासाठी बटण मजकूर." | |
| }, | |
| "hide": "लपवा", | |
| "@hide": { | |
| "description": "दृश्यातून आयटम लपवण्यासाठी बटण मजकूर." | |
| }, |
🤖 Prompt for AI Agents
In `@lib/l10n/app_mr.arb` around lines 1343 - 1346, The "hide" localization entry
currently uses the Marathi string "काढून टाका" (meaning "remove") which
duplicates the "remove" key; update the "hide" key's value to "लपवा" and keep or
adjust the accompanying "@hide.description" if needed to ensure it reads as
"button text to hide an item" consistent with existing keys like "hidePassword"
(use "लपवा" for the value so semantics match the intended hide action).
|
Closing as per #736 |
|
✅ PR Closed - Thank You, @PranjaliBhardwaj!
We appreciate your effort and look forward to more contributions from you! 🤝 |
Description
There were some missing Marathi strings, I added marathi texts for them.
Fixes #736
How Has This Been Tested?
Changes follow JSON format and no lint errors.
Please include screenshots below if applicable.
Checklist:
Maintainer Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.