Skip to content

added 15 missing Marathi strings#737

Closed
PranjaliBhardwaj wants to merge 1 commit intoAOSSIE-Org:masterfrom
PranjaliBhardwaj:missing-marathi
Closed

added 15 missing Marathi strings#737
PranjaliBhardwaj wants to merge 1 commit intoAOSSIE-Org:masterfrom
PranjaliBhardwaj:missing-marathi

Conversation

@PranjaliBhardwaj
Copy link

@PranjaliBhardwaj PranjaliBhardwaj commented Jan 24, 2026

Description

There were some missing Marathi strings, I added marathi texts for them.
Fixes #736

How Has This Been Tested?

Changes follow JSON format and no lint errors.

Please include screenshots below if applicable.

Checklist:

  • [✅ ] My code follows the style guidelines of this project
  • [ ✅] I have performed a self-review of my own code
  • [ ✅] I have commented my code, particularly in hard-to-understand areas
  • [ ✅] I have made corresponding changes to the documentation
  • [ ✅] My changes generate no new warnings
  • [ ✅] I have added tests that prove my fix is effective or that my feature works
  • [ ✅] New and existing unit tests pass locally with my changes
  • [ ✅] Any dependent changes have been merged and published in downstream modules
  • [ ✅] I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

Summary by CodeRabbit

  • Localization
    • Added Marathi language translations for search functionality, room filtering, and room management features
    • Included localized text for removal workflows, confirmation dialogs, error messages, and success notifications

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Pranjali Bhardwaj <pranjalisharma6543@gmail.com>
@github-actions
Copy link
Contributor

🎉 Welcome @PranjaliBhardwaj!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@coderabbitai
Copy link

coderabbitai bot commented Jan 24, 2026

📝 Walkthrough

Walkthrough

This PR adds 16 new localization keys to the Marathi language file (app_mr.arb), covering search functionality, room management, and message deletion features. Each key includes both the translation string and metadata description entries.

Changes

Cohort / File(s) Summary
Localization Keys for Search, Room Management, and Message Deletion
lib/l10n/app_mr.arb
Added 16 new translation keys with descriptions: search-related keys (search, clear, searchRooms, searchingRooms, clearSearch, searchError, searchFailed, searchRoomsError, searchUpcomingRoomsError), room management keys (hide, removeRoom, removeRoomFromList, removeRoomConfirmation, failedToRemoveRoom, roomRemovedSuccessfully), and message deletion keys (deleteMessageTitle, deleteMessageContent). All entries include @description metadata blocks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Release v3.0.0 #601: Modifies the same Marathi localization file to add and wire localization keys into the app's resources.

Suggested labels

app-update

Poem

🐰 Marathi strings hop into place,
Search and rooms find their space,
With delete and hide so neat,
The translation is complete!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'added 15 missing Marathi strings' directly and clearly summarizes the main change: adding missing Marathi localization strings to app_mr.arb file.
Linked Issues check ✅ Passed The PR adds 18 new localization strings and their descriptions to app_mr.arb, fulfilling issue #736's requirement to add missing Marathi localization lines for complete coverage.
Out of Scope Changes check ✅ Passed All changes are limited to lib/l10n/app_mr.arb file adding only localization keys and descriptions, directly aligned with the scope of resolving missing Marathi strings in issue #736.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
lib/l10n/app_mr.arb (1)

1761-1768: Fix inconsistent indentation for the new entries.

Lines 1762-1768 have inconsistent indentation compared to the rest of the file, which uses 4-space indentation. This affects code maintainability and style consistency.

Suggested fix
     "deleteMessageTitle": "संदेश हटवा",
-"@deleteMessageTitle": {
-  "description": "Delete message पुष्टी संवादात शीर्षक दाखवले जाते."
-},
-"deleteMessageContent": "आपण खरोखर हा संदेश हटवू इच्छिता का?",
-"@deleteMessageContent": {
-  "description": "वापरकर्त्याला विचारले जाणारे पुष्टीकरण मजकूर की तो संदेश हटवू इच्छितो का."
-}
+    "@deleteMessageTitle": {
+        "description": "Delete message पुष्टी संवादात शीर्षक दाखवले जाते."
+    },
+    "deleteMessageContent": "आपण खरोखर हा संदेश हटवू इच्छिता का?",
+    "@deleteMessageContent": {
+        "description": "वापरकर्त्याला विचारले जाणारे पुष्टीकरण मजकूर की तो संदेश हटवू इच्छितो का."
+    }
🤖 Fix all issues with AI agents
In `@lib/l10n/app_mr.arb`:
- Around line 1343-1346: The "hide" localization entry currently uses the
Marathi string "काढून टाका" (meaning "remove") which duplicates the "remove"
key; update the "hide" key's value to "लपवा" and keep or adjust the accompanying
"@hide.description" if needed to ensure it reads as "button text to hide an
item" consistent with existing keys like "hidePassword" (use "लपवा" for the
value so semantics match the intended hide action).
🧹 Nitpick comments (1)
lib/l10n/app_mr.arb (1)

951-958: Duplicate translations for searchFailed and searchRoomsError.

Both keys have identical Marathi translations: "कोठे शोधणे अयोग्य. कृपया पुन्हा प्रयत्न करा." Consider whether these should have differentiated messages based on their distinct descriptions, or if one key is redundant.

Comment on lines +1343 to +1346
"hide": "काढून टाका",
"@hide": {
"description": "दृश्यातून आयटम काढून टाकण्यासाठी बटण मजकूर."
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Translation for hide should be "लपवा" not "काढून टाका".

The key hide is translated as "काढून टाका" which means "remove" - the same as the existing remove key at line 1339. This creates semantic ambiguity. The file already uses "लपवा" for hiding actions (see hidePassword at line 11: "पासवर्ड लपवा").

Suggested fix
-    "hide": "काढून टाका",
+    "hide": "लपवा",
     "@hide": {
-        "description": "दृश्यातून आयटम काढून टाकण्यासाठी बटण मजकूर."
+        "description": "दृश्यातून आयटम लपवण्यासाठी बटण मजकूर."
     },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"hide": "काढून टाका",
"@hide": {
"description": "दृश्यातून आयटम काढून टाकण्यासाठी बटण मजकूर."
},
"hide": "लपवा",
"@hide": {
"description": "दृश्यातून आयटम लपवण्यासाठी बटण मजकूर."
},
🤖 Prompt for AI Agents
In `@lib/l10n/app_mr.arb` around lines 1343 - 1346, The "hide" localization entry
currently uses the Marathi string "काढून टाका" (meaning "remove") which
duplicates the "remove" key; update the "hide" key's value to "लपवा" and keep or
adjust the accompanying "@hide.description" if needed to ensure it reads as
"button text to hide an item" consistent with existing keys like "hidePassword"
(use "लपवा" for the value so semantics match the intended hide action).

@M4dhav
Copy link
Contributor

M4dhav commented Feb 11, 2026

Closing as per #736

@M4dhav M4dhav closed this Feb 11, 2026
@github-actions
Copy link
Contributor

PR Closed - Thank You, @PranjaliBhardwaj!

  • If this PR was merged: Congratulations! Your contribution is now part of the project. 🚀
  • If this PR was closed without merging: Don’t worry! You can always improve it and submit again. 💪

We appreciate your effort and look forward to more contributions from you! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Marathi Strings

2 participants