-
Notifications
You must be signed in to change notification settings - Fork 4
Add triage #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add triage #51
Conversation
…into kpj2006-pre-issue
Updated issue template for CI/CD to focus on deployment pipeline setup and removed obsolete testing tasks.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
📝 WalkthroughWalkthroughThis pull request adds a "triage-needed" label to three issue templates, introduces a JSON file containing predefined issues with metadata, and creates a GitHub Actions workflow to automate issue creation from that JSON file, with cleanup upon completion. Changes
Sequence Diagram(s)sequenceDiagram
participant GHA as GitHub Actions
participant Repo as Repository
participant API as GitHub API
participant Git as Git Operations
GHA->>Repo: Checkout code (actions/checkout@v4)
GHA->>Repo: Check if initial-issues.json exists
alt File does not exist
GHA->>GHA: Log skip message
else File exists
GHA->>Repo: Read initial-issues.json
GHA->>GHA: Parse & validate JSON structure
loop For each issue in array
GHA->>API: Create issue with title, body, labels
API-->>GHA: Issue created
GHA->>GHA: Log issue result
end
GHA->>GHA: Aggregate success/failure summary
alt All issues created successfully
GHA->>Repo: Delete initial-issues.json
GHA->>Repo: Delete create-initial-issues.yml workflow
GHA->>Git: Stage deletions
GHA->>Git: Commit cleanup changes
GHA->>Git: Rebase & push to branch
else Any creation failed
GHA->>GHA: Fail workflow step
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (3)
.github/initial-issues.json (2)
1-11: Consider addingtriage-neededlabel for consistency.The issue templates (
bug_report.yml,feature_request.yml,good_first_issue.yml) now include thetriage-neededlabel, but issues created from this JSON file will not have it. If this is intentional (pre-triaged issues don't need triage), this is fine. Otherwise, consider adding"triage-needed"to each issue's labels array for a consistent workflow.
76-85: Minor: Unnecessary blank line in JSON array.Line 76 contains an empty line within the array. While valid JSON, it's slightly inconsistent with the formatting of other entries.
.github/workflows/create-initial-issues.yml (1)
58-73: Consider adding rate limiting for bulk issue creation.Creating 27 issues in rapid succession may hit GitHub's secondary rate limits. Consider adding a small delay between issue creations to avoid throttling.
🔎 Proposed fix
// Create each issue for (const issue of issuesData.issues) { try { const response = await github.rest.issues.create({ owner: context.repo.owner, repo: context.repo.repo, title: issue.title, body: issue.body, labels: issue.labels || [] }); console.log(`✓ Created issue #${response.data.number}: ${issue.title}`); successCount++; + // Small delay to avoid hitting secondary rate limits + await new Promise(resolve => setTimeout(resolve, 1000)); } catch (error) { console.error(`✗ Failed to create issue "${issue.title}":`, error.message); failCount++; } }
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/ISSUE_TEMPLATE/bug_report.yml.github/ISSUE_TEMPLATE/feature_request.yml.github/ISSUE_TEMPLATE/good_first_issue.yml.github/initial-issues.json.github/workflows/create-initial-issues.yml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-25T01:19:20.143Z
Learnt from: kpj2006
Repo: AOSSIE-Org/Template-Repo PR: 4
File: .github/workflows/release-drafter.yml:4-7
Timestamp: 2025-12-25T01:19:20.143Z
Learning: In the Template-Repo (AOSSIE-Org/Template-Repo), the release-drafter workflow intentionally includes both `main` and `master` branches in the trigger configuration because it's a template repository that needs to support projects using either branch naming convention.
Applied to files:
.github/workflows/create-initial-issues.yml
🔇 Additional comments (5)
.github/ISSUE_TEMPLATE/bug_report.yml (1)
4-4: LGTM!The addition of the
triage-neededlabel is correctly formatted. Ensure thetriage-neededlabel exists in the repository settings, or it will be auto-created when the first issue is filed using this template..github/ISSUE_TEMPLATE/good_first_issue.yml (1)
4-4: LGTM!Consistent with the other template updates to include the
triage-neededlabel..github/ISSUE_TEMPLATE/feature_request.yml (1)
4-4: LGTM!Consistent with the other template updates.
.github/workflows/create-initial-issues.yml (2)
3-8: Workflow triggers on bothmainandmasterbranches.This is appropriate for a template repository that needs to support projects using either branch naming convention. Based on learnings from this repository, this dual-branch pattern is intentional.
13-16: Concurrency and conditional logic look good.The concurrency group with
cancel-in-progress: falseensures sequential execution, and the condition correctly prevents the workflow from running on the template repo itself while restricting it to AOSSIE-Org repositories.
Addressed Issues:
Fixes #(issue number)
Screenshots/Recordings:
Additional Notes:
Checklist
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.