Added the label change for spiff#82
Merged
auslin-aot merged 3 commits intoAOT-Technologies:mainfrom Mar 19, 2026
Merged
Conversation
abilpraju-aot
requested review from
andrepestana-aot,
auslin-aot,
sonal-aot and
vinaayakh-aot
| const replacements = [ | ||
| { | ||
| from: "translate('Spiffworkflow Service Properties')", | ||
| to: "translate('m8flow Service Properties')", |
Collaborator
There was a problem hiding this comment.
M8Flow should have the "M" capitalized.
|
|
||
| for (const { from, to } of replacements) { | ||
| if (content.includes(from)) { | ||
| content = content.replace(from, to); |
Collaborator
There was a problem hiding this comment.
This is just a work around. If it's just treated as so, it's ok, but we need to discuss it and consider forking sartography/bpmn-js-spiffworkflow as we may need to do other customizations.
Collaborator
Author
There was a problem hiding this comment.
ya agree with your point this is only for quick fix
|
auslin-aot
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
https://aottech.atlassian.net/browse/M8F-150
Description
Overrided the label for spiff service property
Type
Changes
Testing
Related Issues
Closes #