Skip to content

Conversation

erunion
Copy link
Contributor

@erunion erunion commented Jan 22, 2025

This creates a new options.dereference.onCircular hook that will be executed when a circular $ref is detected, and similar to onDereference, will allow consumers to accumulate a list of circular references within their schemas.

I have written a test for this, and also updated a few test case typos where they were using the legacy options.$refs property instead of options.dereference.

Closes out #358

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12918473069

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 92.04%

Totals Coverage Status
Change from base Build 12190033497: -0.03%
Covered Lines: 1569
Relevant Lines: 1676

💛 - Coveralls

@jonluca jonluca merged commit 50929bb into APIDevTools:main Jan 23, 2025
13 of 14 checks passed
@jonluca
Copy link
Collaborator

jonluca commented Jan 23, 2025

Looks great! Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants