Fix dereference and bundle issues (#338, #370, #395)#409
Merged
Conversation
- Fix #370: Reset false circular detection for extended $refs during pointer token walking to handle Pydantic-style schemas with $ref alongside $defs - Fix #338: Add post-processing in bundle() to correct $ref paths that incorrectly traverse through other $ref nodes - Fix #395: Add maxDepth option to dereference (default 500) to prevent stack overflow on deeply nested schemas - All fixes include comprehensive tests and pass full test suite (298 tests)
Pull Request Test Coverage Report for Build 22526506716Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three important issues in the dereference and bundle operations:
$ref(sibling keys alongside$ref)$refpaths that traverse through other$refnodes, violating JSON Schema specmaxDepthoption to dereference (default 500) to prevent stack overflow on deeply nested schemasTesting
All fixes include comprehensive test coverage and pass the full test suite (298 tests, 56 test files, zero regressions).