fix: resolve open issues #349, #355, #392 with regression tests#415
Merged
fix: resolve open issues #349, #355, #392 with regression tests#415
Conversation
…on tests - Add `dereference.cloneReferences` option to create independent copies of dereferenced values via structuredClone, preventing shared-reference mutations (#349) - Fix bundle creating invalid cross-$id $ref pointers by qualifying refs with the root document's $id when inside a sub-schema $id scope (#355) - Add `bundle.optimizeInternalRefs` option to control whether internal $ref paths get shortened during bundling (#392) - Add regression tests for #384 (externalReferenceResolution) and #403 (circular $ref: "#" in oneOf)
Pull Request Test Coverage Report for Build 22527114945Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dereference.cloneReferencesoption that usesstructuredCloneto create independent copies of dereferenced values, preventing mutations to one$reflocation from affecting others$refpointers when sub-schemas have$id. Refs are now qualified with the root document's$idto avoid JSON Schema$idscoping issuesbundle#392 — Addbundle.optimizeInternalRefsoption (defaults totrue) to control whether internal$refpaths get shortened and rewritten during bundlingexternalReferenceResolutioninDereferenceOptionsdoesn't work #384 — Added regression test confirmingexternalReferenceResolutionworks correctly$ref: "#"inoneOfis handled properlyTest plan
yarn test)yarn typecheck)yarn lint)main