Skip to content

Conversation

cehan-Chloe
Copy link

@cehan-Chloe cehan-Chloe commented Apr 30, 2023

migrate from graphql-express to apollo server v4 to allow query batching

In this pr, it includes

  1. dependency upgrade (can't be a separate pr since the express-graphql latest version only support graphql v14 but @apollo-server requires v16)
  2. upgrade to apollo server v4

this is a draft pr not ready for review but for pairing work with Ivan(the repo owner)

@ukch
Copy link

ukch commented Jun 6, 2023

Running npm run build:all gives this error:

ERROR in ./src/editor/index.tsx
Module build failed (from ./node_modules/ts-loader/index.js):
Error: Debug Failure. False expression: Non-string value passed to `ts.resolveTypeReferenceDirective`, likely by a wrapping package working with an outdated `resolveTypeReferenceDirectives` signature. This is probably not a problem in TS itself.
    at Object.resolveTypeReferenceDirective (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:43500:18)
    at /home/joel/src/graphql-faker/node_modules/ts-loader/dist/servicesHost.js:613:77
    at /home/joel/src/graphql-faker/node_modules/ts-loader/dist/servicesHost.js:131:142
    at Array.map (<anonymous>)
    at Object.resolveTypeReferenceDirectives (/home/joel/src/graphql-faker/node_modules/ts-loader/dist/servicesHost.js:131:125)
    at actualResolveTypeReferenceDirectiveNamesWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:119382:163)
    at resolveTypeReferenceDirectiveNamesWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:119682:26)
    at processTypeReferenceDirectives (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121185:31)
    at findSourceFileWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121070:21)
    at findSourceFile (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120922:26)
    at processImportedModules (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121331:25)
    at findSourceFileWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121076:17)
    at findSourceFile (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120922:26)
    at processImportedModules (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121331:25)
    at findSourceFileWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121076:17)
    at findSourceFile (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120922:26)
    at processImportedModules (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121331:25)
    at findSourceFileWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121076:17)
    at findSourceFile (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120922:26)
    at processImportedModules (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121331:25)
    at findSourceFileWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121076:17)
    at findSourceFile (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120922:26)
    at processImportedModules (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121331:25)
    at findSourceFileWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121076:17)
    at findSourceFile (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120922:26)
    at processImportedModules (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121331:25)
    at findSourceFileWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121076:17)
    at findSourceFile (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120922:26)
    at processImportedModules (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121331:25)
    at findSourceFileWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:121076:17)
    at findSourceFile (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120922:26)
    at /home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120871:85
    at getSourceFileFromReferenceWorker (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120837:34)
    at processSourceFile (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120871:13)
    at processRootFile (/home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:120672:13)
    at /home/joel/src/graphql-faker/node_modules/typescript/lib/typescript.js:119473:67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants