Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 1, 2025

The original PR had a hardcoded 100ms interval for the marker sweep timer. This has been made configurable.

Changes:

  • Added sweepIntervalMs option to plugin constructor (defaults to 100ms)
  • Added frameDurationMs option to configure frame timing assumptions (defaults to 200ms)
  • Added lostThreshold documentation clarifying it's measured in frames
  • Updated _sweepMarkers() to use lostThreshold * frameDurationMs for threshold calculation

Usage:

const plugin = new ArtoolkitPlugin({
  sweepIntervalMs: 50,      // Run cleanup every 50ms
  frameDurationMs: 33,      // Assume ~30fps capture rate
  lostThreshold: 5          // Consider lost after 5 frames (~165ms)
});

Consumers can now tune marker cleanup frequency based on their capture rate and latency requirements.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Address feedback from initial ARToolKit plugin setup Address review feedback: Make sweep interval configurable Nov 1, 2025
Copilot AI requested a review from kalwalt November 1, 2025 23:03
Copilot finished work on behalf of kalwalt November 1, 2025 23:03
@kalwalt kalwalt changed the base branch from copilot/scaffold-artoolkit to main November 1, 2025 23:07
@kalwalt
Copy link
Member

kalwalt commented Nov 1, 2025

@copilot closing we will add in another PR

@kalwalt kalwalt closed this Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants