Skip to content

Conversation

@simpal01
Copy link
Collaborator

@simpal01 simpal01 commented Nov 4, 2024

This adds the following library:

  • armv7a_soft_nofp_strictly_aligned
  • armv7a_soft_nofp_strictly_aligned_exn_rtti

@ostannard
Copy link
Collaborator

strictly_aligned

I think it would be better to keep this as one word with no underscores, so that it is clearer how these parse. exn_rtti doesn't follow that, but it could be considered two separate features, and a rtti variant without exceptions could exist in future (not that I think it should).

Since we are eventually going to want strict-aligned variants for most architectures, would it make more sense to handle it like we do for exn_rtti and expand the library variants inside add_library_variants_for_cpu, instead of adding more calls to it? That will need an extra parameter for now to only enable the new variants for architectures where they work, but will avoid a lot of duplication in the long run, especially when we add big-endian variants which would double everything again if done in the same way.

Rebasing this patch to incorporate all the latest
cmake changes which means new library variants
for strictly aligned added as a seperate json
files.
Copy link
Collaborator

@pratlucas pratlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@simpal01 simpal01 merged commit 00a466f into ARM-software:main Nov 26, 2024
1 check passed
@simpal01 simpal01 deleted the unaligned-lib branch November 26, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants