Skip to content

Permit FVP tests to return a useful exit status. #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Permit FVP tests to return a useful exit status. #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions arm-runtimes/test-support/picolibc-test-wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@
]

disabled_tests_fvp = [
# SDDKW-53824: ":semihosting-features" pseudo-file not implemented.
"test/semihost/semihost-exit-extended",
# SDDKW-25808: SYS_SEEK returns wrong value.
"test/semihost/semihost-seek",
"test/test-fread-fwrite",
Expand Down
12 changes: 12 additions & 0 deletions arm-runtimes/test-support/run_fvp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,18 @@ def run_fvp(
if verbose:
print("running: {}".format(shlex.join(command)))

# SDDKW-53824: the ":semihosting-features" pseudo-file isn't simulated
# by these models. To work around that, we create one ourselves in the
# test process's working directory, containing the single feature flag
# SH_EXT_EXIT_EXTENDED, meaning that the SYS_EXIT_EXTENDED semihosting
# request will work. This permits the test program's exit status to be
# propagated to the exit status of the FVP, so that tests returning 77
# for "test skipped" can be automatically detected.
with open(
path.join(working_directory, ":semihosting-features"), "wb"
) as fh:
fh.write(b"SHFB\x01")

result = subprocess.run(
command,
stdout=subprocess.PIPE,
Expand Down
Loading