-
Notifications
You must be signed in to change notification settings - Fork 66
Add FEAT_PCDPHINT Support #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ricbal02
wants to merge
2
commits into
ARM-software:main
Choose a base branch
from
ricbal02:FEAT_PCDPHINT
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthackray
reviewed
Aug 1, 2025
jthackray
reviewed
Aug 1, 2025
jthackray
reviewed
Aug 1, 2025
Wilco1
reviewed
Aug 4, 2025
Wilco1
reviewed
Aug 4, 2025
Wilco1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x
6ab456b to
af4a611
Compare
Wilco1
reviewed
Sep 1, 2025
ktkachov
reviewed
Sep 16, 2025
af4a611 to
e067f72
Compare
Wilco1
reviewed
Sep 29, 2025
e067f72 to
5977a0e
Compare
mgabka
reviewed
Oct 2, 2025
Wilco1
reviewed
Oct 30, 2025
5977a0e to
7923260
Compare
Author
|
Hi all, I now have a GCC patch for this in Upstream review. Would I be able to get some final approval/review on this ACLE patch. Thanks |
jthackray
approved these changes
Nov 11, 2025
jthackray
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This is a PR to propose the addition of new intrinsics required as part of FEAT_PCDPHINT.
I'm very open to suggestions on potential improvements and certainly not overly committed to the current name.
This will need approval from LLVM as well.
Quality Level: ALP
PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
SPDX-FileCopyrightTextlines on topof any file I have edited. Format is
SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in
2017-2019, and usecommas to separate gaps, as in
2018-2020, 2022).Copyrightsection of the sources of thespecification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
draftversionis set totruein the YAML headerof the sources of the specifications I have modified.
in the README page of the project.