fix cfg generator spelling of pbtext extension #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"pbtxt" is not accepted by code_generator
Also add -fcf-protection=none in commented CFLAGS for disabling CET / indirect branch tracking endbr64 instructions.
xyzsam
reviewed
Nov 3, 2020
Collaborator
xyzsam
left a comment
xyzsam
left a comment
There was a problem hiding this comment.
pbtxt is the canonical file extension for text protos, not pbtext. We should update code_generator instead; that's where the bug is.
Also, can you split out the Makefile changes to a separate PR?
Collaborator
|
FYI - I just sent PR #22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"pbtxt" is not accepted by code_generator