tests

joshjennings98 · joshjennings98 · commit 6d1afd04f6bd · 2025-04-07T10:13:29.000+01:00
diff --git a/utils/api/api_test.go b/utils/api/api_test.go
@@ -58,6 +58,15 @@ func TestCheckAPICallSuccess(t *testing.T) {
 		assert.Equal(t, actualErr.Error(), expectedErr)
 	})
 
+	t.Run("api call not successful (no JSON response)", func(t *testing.T) {
+		errMessage := "response error"
+		parentCtx := context.Background()
+		resp := _http.Response{StatusCode: 403, Body: io.NopCloser(bytes.NewReader([]byte("<html><head><title>403 Forbidden</title></head></html>")))}
+		actualErr := CheckAPICallSuccess(parentCtx, errMessage, &resp, errors.New("403 Forbidden"))
+		expectedErr := "response error (403): <html><head><title>403 Forbidden</title></head></html>; 403 Forbidden"
+		assert.Equal(t, actualErr.Error(), expectedErr)
+	})
+
 	t.Run("no context error, api call successful", func(t *testing.T) {
 		errMessage := "no error"
 		parentCtx := context.Background()
diff --git a/utils/errors/errors_test.go b/utils/errors/errors_test.go
@@ -45,6 +45,13 @@ func TestFetchAPIErrorDescription(t *testing.T) {
 		expectedMessage := ""
 		assert.Equal(t, expectedMessage, actualMessage)
 	})
+
+	t.Run("error response is not JSON", func(t *testing.T) {
+		resp := _http.Response{Body: io.NopCloser(bytes.NewReader([]byte("<html><head><title>403 Forbidden</title></head></html>")))}
+		actualMessage := FetchAPIErrorDescription(&resp)
+		expectedMessage := "<html><head><title>403 Forbidden</title></head></html>"
+		assert.Equal(t, expectedMessage, actualMessage)
+	})
 }
 
 func TestFetchAPIErrorDescriptionInterrupt(t *testing.T) {
