Skip to content

Timeline layer: Add missing render pass tracker end calls #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solidpixel merged 1 commit into from
Jul 22, 2025
Merged

Timeline layer: Add missing render pass tracker end calls #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions layer_gpu_timeline/source/layer_device_functions_render_pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,11 @@ VKAPI_ATTR void VKAPI_CALL layer_vkCmdEndRenderPass2<user_tag>(VkCommandBuffer c
std::unique_lock<std::mutex> lock {g_vulkanLock};
auto* layer = Device::retrieve(commandBuffer);

// Update the layer command stream in the tracker
auto& tracker = layer->getStateTracker();
auto& cb = tracker.getCommandBuffer(commandBuffer);
cb.renderPassEnd();

// Release the lock to call into the driver
lock.unlock();
layer->driver.vkCmdEndRenderPass2(commandBuffer, pSubpassEndInfo);
Expand All @@ -340,6 +345,11 @@ VKAPI_ATTR void VKAPI_CALL layer_vkCmdEndRenderPass2KHR<user_tag>(VkCommandBuffe
std::unique_lock<std::mutex> lock {g_vulkanLock};
auto* layer = Device::retrieve(commandBuffer);

// Update the layer command stream in the tracker
auto& tracker = layer->getStateTracker();
auto& cb = tracker.getCommandBuffer(commandBuffer);
cb.renderPassEnd();

// Release the lock to call into the driver
lock.unlock();
layer->driver.vkCmdEndRenderPass2KHR(commandBuffer, pSubpassEndInfo);
Expand Down