-
Notifications
You must be signed in to change notification settings - Fork 33
FIPS 204 - API for Module Lattice-based signatures (ML-DSA) #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3263b68
Define key types and algorithms for FIPS 204 ML-DSA
athoelke 01fa88c
Use the seed as the ML-DSA key pair export format.
athoelke a6993f9
Do not group ML-DSA keys and ML-KEM keys together.
athoelke ac438ff
Fix spelling
athoelke a747d19
Treat hedged/deterministic ML-DSA verification algorithms as equivale…
athoelke 2345aae
Provide rationale for distinct hedged/deterministic algorithms
athoelke b757c94
Reflect the algorithm distinction between ML-DSA and HashML-DSA
athoelke 30915a4
Correct algorithm summary text
athoelke 809eb45
fixup: missing change in example macro implementations
athoelke ce5a8fd
Add FIPS204 recommendations for algorithm selection
athoelke 70d06a7
Clarification on ML-DSA deterministic vs hedged
athoelke c724f7a
Add warning about ongoing standardization of ML-DSA key formats
athoelke 229d018
Provide reference to IETF LAMPS draft for ML-DSA key formats
athoelke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add a note on hedged versus deterministic here. Perhaps:
.. admonition:: Note
FIPS 204 defines the "hedged" and deterministic versions. The hedged version provides message secrecy and some protection against side-channels. FIPS 204 recommends that users should use the hedged version if either of these issues are a concern. The deterministic variant should only be used if the implementation does not include any source of randomness.
.. admonition:: Implementation note
FIPS 204 recommends that implementations use an approved random number generator to provide the random value in the hedged version. However, it notes that use of the hedged variant with a weak RNG is generally preferable to the deterministic variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that putting it here, with the key types is the right place - these should be with the algorithms. Perhaps this text would work well in the ML-DSA algorithm overview where it discusses Hedged and Deterministic variants?
I would leave the warning (from the last commit) in the description of
PSA_ALG_DETERMINISTIC_ML_DSA.