Skip to content

Encapsulation #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcusJGStreets wants to merge 8 commits into from
Closed

Encapsulation #220

MarcusJGStreets wants to merge 8 commits into from

Conversation

@MarcusJGStreets
Copy link
Contributor

@MarcusJGStreets MarcusJGStreets commented Oct 2, 2024

Adding ECIES and ML-KEM

athoelke
athoelke reviewed Oct 3, 2024
View reviewed changes
athoelke
athoelke reviewed Oct 3, 2024
View reviewed changes
athoelke
athoelke reviewed Oct 3, 2024
View reviewed changes
@MarcusJGStreets
Addressing Andrew's comments
df06985 
Removing references to ML-DSA in ML-KEM section

Signed-off-by: Marcus Streets <[email protected]>
athoelke
athoelke requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@athoelke athoelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the revised & resubmitted PR.

@MarcusJGStreets
Answering Andrew's comments Oct 14
b59f16e 
Signed-off-by: Marcus Streets <[email protected]>
@MarcusJGStreets
Answering Andrew's comments Oct 14
5b2bfc0 
Signed-off-by: Marcus Streets <[email protected]>
@MarcusJGStreets
Answering Andrew's comments Oct 14
109b81a 
Still need to add new figure (and its licence file)

Signed-off-by: Marcus Streets <[email protected]>
@MarcusJGStreets
Fixing indents
5ce3f11 
Signed-off-by: Marcus Streets <[email protected]>
@MarcusJGStreets
Add key encoding
4291c5e 
Signed-off-by: Marcus Streets <[email protected]>
This was referenced Oct 21, 2024
Merged
Merged
@athoelke athoelke marked this pull request as draft October 22, 2024 14:03
@athoelke
Copy link
Contributor

athoelke commented Oct 22, 2024

These APIs have been split between Encapsulation & ECIES support (in #222), and ML-KEM support in the PQC extension (#223).

@athoelke
Copy link
Contributor

athoelke commented Dec 16, 2024

This update has now been merged via
#222 and #223

@athoelke athoelke closed this Dec 16, 2024
@athoelke athoelke deleted the New_encap branch December 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@athoelke athoelke athoelke requested changes

Assignees

No one assigned

Labels

DO NOT MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcusJGStreets @athoelke