Add Nordic NRF52840 USB Dongle board#15504
Open
hallard wants to merge 5 commits intoARMmbed:masterfrom
Open
Conversation
added NRF52840 Dongle
fixed missing library
fixed deprecated pin name
use define for led, button, spi and i2c
added NRF52840_DONGLE
Contributor
|
Can you please attach test logs for this addition to the first comment? It should be part of every new target addition. |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Contributor
|
Can you run some tests (it uses the implementation provided just checking if the device is properly configured). |
Contributor
Author
|
I'll try to do that tomorrow, sorry for delay, could you remind me test command you want results for? |
Contributor
|
I haven't run the tests for some time but as I recall if you use arguments platform and toolchain, it would run the default set of tests for that platform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Nordic NRF52840 USB Dongle board
Summary of changes
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@jeromecoutant