Skip to content

a set of minor fixes to get rid of some build warnings #15534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

a set of minor fixes to get rid of some build warnings #15534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3508a88
fix: warning: ISO C++ forbids converting a string constant to char*
Ole2mail Aug 7, 2025
5f37567
fix: warning: 'port_start' may be used uninitialized in this function
Ole2mail Aug 7, 2025
4c0e892
fix: warning: 'status' may be used uninitialized in this function
Ole2mail Aug 7, 2025
c2c3c64
fix: warning: 'active_direct_confirm' may be used uninitialized in th…
Ole2mail Aug 7, 2025
1fe7cb7
fix: warning: unused variable 'led_err'
Ole2mail Aug 7, 2025
746fd4f
fix: warning: unused variable 'ret'
Ole2mail Aug 7, 2025
5ca33de
fix: warning: unused variable 'pin'
Ole2mail Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../FEATURE_BLE/libraries/TARGET_CORDIO_LL/stack/controller/sources/ble/lctr/lctr_main_iso.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ uint8_t LctrIsoReadTestCounter(uint16_t handle, LlIsoTestCtrs_t *pStats)
/*************************************************************************************************/
uint8_t LctrIsoTestEnd(uint16_t handle, LlIsoTestCtrs_t *pStats)
{
uint8_t status;
uint8_t status = LL_ERROR_CODE_UNSPECIFIED_ERROR;
lctrCisCtx_t *pCisCtx;
lctrBisCtx_t *pBisCtx;

Expand Down
2 changes: 1 addition & 1 deletion connectivity/cellular/include/cellular/framework/AT/AT_CellularDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class AT_CellularDevice : public CellularDevice {
};

public:
AT_CellularDevice(FileHandle *fh, char *delim = "\r");
AT_CellularDevice(FileHandle *fh, const char *delim = "\r");
virtual ~AT_CellularDevice();

virtual nsapi_error_t clear();
Expand Down
2 changes: 1 addition & 1 deletion connectivity/cellular/source/framework/AT/AT_CellularDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ using namespace std::chrono_literals;
#define DEFAULT_AT_TIMEOUT 1s // at default timeout
const int MAX_SIM_RESPONSE_LENGTH = 16;

AT_CellularDevice::AT_CellularDevice(FileHandle *fh, char *delim):
AT_CellularDevice::AT_CellularDevice(FileHandle *fh, const char *delim):
CellularDevice(),
_at(fh, _queue, DEFAULT_AT_TIMEOUT, delim),
#if MBED_CONF_CELLULAR_USE_SMS
Expand Down
2 changes: 1 addition & 1 deletion connectivity/drivers/cellular/GEMALTO/CINTERION/GEMALTO_CINTERION_CellularStack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ nsapi_size_or_error_t GEMALTO_CINTERION_CellularStack::socket_recvfrom_impl(Cell
if (address) {
char *ip_start = ip_address;
char *ip_stop;
char *port_start;
char *port_start = (char *)0xDEADBEEF;
if (_stack_type == IPV6_STACK) {
ip_start++; // skip '['
ip_stop = strchr(ip_address, ']');
Expand Down
2 changes: 1 addition & 1 deletion connectivity/nanostack/sal-stack-nanostack/source/6LoWPAN/adaptation_interface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,7 +1554,7 @@ int8_t lowpan_adaptation_interface_tx_confirm(protocol_interface_info_entry_t *c

//Check first
fragmenter_tx_entry_t *tx_ptr;
bool active_direct_confirm;
bool active_direct_confirm = false;
if (lowpan_active_tx_handle_verify(confirm->msduHandle, interface_ptr->active_broadcast_tx_buf.buf)) {
active_direct_confirm = true;
tx_ptr = &interface_ptr->active_broadcast_tx_buf;
Expand Down
2 changes: 1 addition & 1 deletion platform/source/mbed_board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ WEAK MBED_NORETURN void mbed_die(void)
#if !defined(TARGET_EFM32)
core_util_critical_section_enter();
#endif
gpio_t led_err;
#ifdef LED1
gpio_t led_err;
gpio_init_out(&led_err, LED1);
#endif

Expand Down
2 changes: 1 addition & 1 deletion storage/kvstore/tdbstore/source/TDBStore.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,7 +1490,7 @@ int TDBStore::check_erase_before_write(uint8_t area, uint32_t offset, uint32_t s
uint32_t end_offset;
while (size) {
uint32_t dist, offset_from_start;
int ret;
// int ret;
offset_in_erase_unit(area, offset, offset_from_start, dist);
uint32_t chunk = std::min(size, dist);

Expand Down
2 changes: 1 addition & 1 deletion targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/spi_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ void spi_get_capabilities(PinName ssel, bool slave, spi_capabilities_t *cap)

// check if given ssel pin is in the cs pinmap
const PinMap *cs_pins = spi_master_cs_pinmap();
PinName pin = NC;
// PinName pin = NC;
while (cs_pins->pin != NC) {
if (cs_pins->pin == ssel) {
#if DEVICE_SPISLAVE
Expand Down