Skip to content

Commit 64002b9

Browse files
committed
fix(unity-bootstrap-theme): added style for small and medium hero
UDS-1765
1 parent 0e0c04b commit 64002b9

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ div[class^="uds-hero"] {
212212
}
213213

214214
div.uds-hero-sm {
215-
height: $uds-size-spacing-32;
215+
min-height: $uds-size-spacing-32;
216216
grid-template-rows: 1fr auto auto 3rem;
217217

218218
h1,
@@ -255,7 +255,7 @@ div.uds-hero-sm {
255255
}
256256

257257
div.uds-hero-md {
258-
height: 21rem;
258+
min-height: 21rem;
259259
// by design, the hero-md has no content on mobile, change grid template rows and hide .content
260260
grid-template-rows: 1fr auto auto 3rem;
261261

@@ -379,7 +379,7 @@ div.uds-hero-lg {
379379
grid-template-rows: 1fr auto auto $uds-size-spacing-7;
380380
&.has-btn-row {
381381
.btn-row {
382-
top: 14.5rem;
382+
top: 92%;
383383
}
384384
}
385385

@@ -391,7 +391,7 @@ div.uds-hero-lg {
391391
}
392392

393393
div.uds-hero-md {
394-
height: $uds-size-spacing-64;
394+
min-height: $uds-size-spacing-64;
395395
// TODO; remove this, it's a fallback for buttons without has-btn-row
396396
grid-template-rows: 1fr repeat(4, auto) $uds-size-spacing-6;
397397
h1 {

packages/unity-bootstrap-theme/src/scss/extends/_xx_Hero-Competing.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,18 +61,18 @@ div[class^='uds-hero'] {
6161
}
6262

6363
&.uds-hero-sm {
64-
height: $uds-size-spacing-32;
64+
min-height: $uds-size-spacing-32;
6565
.hero-body {
6666
display: none;
6767
}
6868
}
6969

7070
&.uds-hero-md {
71-
height: $uds-size-spacing-64;
71+
min-height: $uds-size-spacing-64;
7272
}
7373

7474
&.uds-hero-lg {
75-
height: 42.75rem;
75+
min-height: 42.75rem;
7676
}
7777
}
7878

0 commit comments

Comments
 (0)