Open
Conversation
Tornio2
requested review from
Aleks1908,
MagdalenaZh and
georginikolov7
as code owners
georginikolov7
requested changes
Feb 18, 2026
Collaborator
georginikolov7
left a comment
georginikolov7
left a comment
There was a problem hiding this comment.
Great Job! Just a couple of minor things I did not tell you in advance.
| "avatar_url": doc["avatar_url"], | ||
| "departments": doc["departments"], | ||
| "social_links": doc["social_links"], | ||
| "departments": doc.get("departments", []), |
| created_at: string; | ||
| updated_at: string; | ||
| name: string; | ||
| member_type: 'member' | 'admin'; |
Collaborator
There was a problem hiding this comment.
Fuck me totally forgot to tell you that member_type should not be sent in the request, nor visible in the form. It is for the BE to distinguish admins and non admins. Role changing will have a different interface
| // TypeScript interface for the backend response | ||
| export interface BackendHubMember { | ||
| id: string; | ||
| created_at: string; |
Collaborator
There was a problem hiding this comment.
Unless you use these somewhere you can drop created at and updated at
| .min(2, { message: 'Name must be at least 2 characters' }) | ||
| .max(50, { message: 'Name must be less than 50 characters' }), | ||
| // TypeScript interface for the backend response | ||
| export interface BackendHubMember { |
Collaborator
There was a problem hiding this comment.
Also because this will also be used on the main page's meet the team section, you can rename the interfaced to just HubMember and move it to /web/src/types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meet the team page wired up with the backend
I added minimal backend changes (safe defaults with .get()) to handle existing database records that were missing the departments field. Without these changes, the GET endpoint returns 500 errors. The frontend is fully functional with these fixes.
Closes #1217