Refactor webui() function for better readability and maintainability #17043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassantoscode
requested review from
AUTOMATIC1111,
catboxanon and
w-e-w
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the webui() function by breaking it down into smaller, well-defined helper functions.
Changes include:
Extracting temporary directory cleanup into clear_temp_dir()
Separating UI setup into configure_ui()
Encapsulating auto-launch browser logic in decide_auto_launch()
Moving interface launching to launch_interface()
Isolating middleware protection in protect_app()
Grouping API setup in configure_apis()
Adding a dedicated function monitor_commands() for server command handling
These changes improve readability, make the code easier to maintain, and facilitate future enhancements or debugging.