Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb6a5023f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
schaubh
force-pushed
the
feature/deprecate_show_plots
branch
from
bb6a502 to
78d871a
Compare
schaubh
force-pushed
the
feature/deprecate_show_plots
branch
3 times, most recently
from
b5cc14e to
75cd168
Compare
This feature was never really used. If we want an interactive use of figure we just run `python test_xxxx.py`.
Will throw a warning to remove show_plots after the cutoff date.
schaubh
force-pushed
the
feature/deprecate_show_plots
branch
from
75cd168 to
17b6f90
Compare
leahkiner
approved these changes
Feb 16, 2026
Contributor
leahkiner
left a comment
leahkiner
left a comment
There was a problem hiding this comment.
This is looking good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pytestin BSK has the custom flagshow_plotsthat can be provided to forcepytestto show the plots for each test file. I can't remember ever using it, and none of the AVS lab BSK users are using it.The use of this flag is now depreciated and throws a warning. After a year this flag functionality will be removed. At that time, the aim is to have all pytest runs use a non-interactive AGG environment. The test runs have no need for the more complex interactive environment.
Verification
Move the deprecation date forward and backward to ensure the expected warnings did appear in the console.
Documentation
Updated release notes. Added a test that will warn me in one year that this flag can be removed.
Future work
Remove the
show_plotsflag one year from now.