Add MuJoCo formation-flying scenario with OE feedback#1267
Open
juan-g-bonilla wants to merge 5 commits intodevelopfrom
Open
Add MuJoCo formation-flying scenario with OE feedback#1267juan-g-bonilla wants to merge 5 commits intodevelopfrom
juan-g-bonilla wants to merge 5 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec94c1e045
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/simulation/mujocoDynamics/linearTimeInvariantSystem/orbitalElementControl.cpp
Show resolved
Hide resolved
src/simulation/mujocoDynamics/linearTimeInvariantSystem/orbitalElementControl.cpp
Show resolved
Hide resolved
src/simulation/mujocoDynamics/cmdForceInertialToForceAtSite/cmdForceInertialToForceAtSite.cpp
Outdated
Show resolved
Hide resolved
d4598c3 to
8744b1d
Compare
4881452 to
246c685
Compare
schaubh
requested changes
Feb 16, 2026
Contributor
schaubh
left a comment
There was a problem hiding this comment.
mostly small stuff, nice PR!
...mujocoDynamics/cmdForceInertialToForceAtSite/_UnitTest/test_cmdForceInertialToForceAtSite.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/orbitControl/orbElemOffset/_UnitTest/test_orbElemOffset.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/orbitControl/orbElemOffset/_UnitTest/test_orbElemOffset.py
Outdated
Show resolved
Hide resolved
src/simulation/mujocoDynamics/linearTimeInvariantSystem/_UnitTest/test_orbitalElementControl.py
Outdated
Show resolved
Hide resolved
src/simulation/mujocoDynamics/linearTimeInvariantSystem/_UnitTest/test_orbitalElementControl.py
Outdated
Show resolved
Hide resolved
src/simulation/mujocoDynamics/linearTimeInvariantSystem/orbitalElementControl.cpp
Show resolved
Hide resolved
src/simulation/mujocoDynamics/linearTimeInvariantSystem/orbitalElementControl.cpp
Show resolved
Hide resolved
src/simulation/mujocoDynamics/linearTimeInvariantSystem/_UnitTest/test_orbitalElementControl.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/orbitControl/orbElemOffset/_UnitTest/test_orbElemOffset.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/orbitControl/orbElemOffset/_UnitTest/test_orbElemOffset.py
Outdated
Show resolved
Hide resolved
246c685 to
988011b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch adds a MuJoCo-based formation-flying scenario and the supporting modules needed to command deputy control forces from orbital-element feedback.
Commits are organized by feature:
CmdForceInertialToForceAtSite(module, SWIG, unit test, docs).orbElemOffset(module, SWIG, unit test, docs).OrbitalElementControlas aLinearTimeInvariantSystemsubclass (module, SWIG update, unit test, docs).examples/mujoco/scenarioFormationFlyingWithDrag.pyand indexes it inexamples/_default.rst.docs/source/Support/bskReleaseNotes.rstwith the new modules/scenario.Verification
Validation artifacts included in this branch:
src/simulation/mujocoDynamics/cmdForceInertialToForceAtSite/_UnitTest/test_cmdForceInertialToForceAtSite.pysrc/fswAlgorithms/orbitControl/orbElemOffset/_UnitTest/test_orbElemOffset.pysrc/simulation/mujocoDynamics/linearTimeInvariantSystem/_UnitTest/test_orbitalElementControl.pytest_scenarioMujoco.pyruns the new scenario.Test intent:
cmdForceInertialToForceAtSite: verifies inertial-to-site force rotation and source-priority behavior (NavAttover fallbackSCStates).orbElemOffset: verifies element-wise offset mode and mean-anomaly-offset mode.orbitalElementControl: verifies force output consistency againstmeanOEFeedback(near-zeroJ2) for proportional and integral configurations.Documentation
Documentation updated for all added components:
src/simulation/mujocoDynamics/cmdForceInertialToForceAtSite/cmdForceInertialToForceAtSite.rstsrc/fswAlgorithms/orbitControl/orbElemOffset/orbElemOffset.rstsrc/simulation/mujocoDynamics/linearTimeInvariantSystem/orbitalElementControl.rstexamples/mujoco/scenarioFormationFlyingWithDrag.py(scenario narrative and figures in docstring)examples/_default.rst(scenario indexing)docs/source/Support/bskReleaseNotes.rst(release-note entries)