Skip to content

Remove --clean default flag from setup.py to speed up incremental builds#1269

Merged
ReeceHumphreys merged 2 commits intodevelopfrom
fix/clean-flag
Feb 17, 2026
Merged

Remove --clean default flag from setup.py to speed up incremental builds#1269
ReeceHumphreys merged 2 commits intodevelopfrom
fix/clean-flag

Conversation

@ReeceHumphreys
Copy link
Contributor

@ReeceHumphreys ReeceHumphreys commented Feb 16, 2026

Description

We were always passing in the --clean flag as a default flag when performing builds with pip. This causes a complete clean build every time rather than incremental builds. As such, I removed this flag.

Verification

CI

Documentation

N/A

Future work

N/A

@ReeceHumphreys ReeceHumphreys self-assigned this Feb 16, 2026
@ReeceHumphreys ReeceHumphreys requested a review from a team as a code owner February 16, 2026 07:06
@ReeceHumphreys ReeceHumphreys added bug Something isn't working build Build system or compilation enhancement labels Feb 16, 2026
@ReeceHumphreys ReeceHumphreys moved this to 👀 In review in Basilisk Feb 16, 2026
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment to address in release notes to improve clarity.

@ReeceHumphreys ReeceHumphreys merged commit e6b8ae3 into develop Feb 17, 2026
12 checks passed
@ReeceHumphreys ReeceHumphreys deleted the fix/clean-flag branch February 17, 2026 03:55
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Basilisk Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build Build system or compilation enhancement

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

pip install . -v takes a long time to install on 2nd time even with no changes to code

2 participants