update for new permission checking of notification module#88
Open
update for new permission checking of notification module#88
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Keycloak-based admin/service-account configuration so replication-backend can perform permission checks, plus scripting to provision/migrate existing instances.
Changes:
- Introduces a migration script to add replication-backend Keycloak client credentials and ensure required backend env vars exist.
- Extends
enable-backend.shto create anaam-backendKeycloak client and populate replication-backend basic-auth + Keycloak secret env vars. - Wires new Keycloak admin settings into
replication-backendcontainer configuration and updates.env.templateaccordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
scripts/migrate-permission-check.sh |
New migration script to create/reuse Keycloak client + update instance env files and restart. |
scripts/enable-backend.sh |
Provisions Keycloak client during backend enablement and writes new env vars. |
docker-compose.yml |
Passes Keycloak admin config into replication-backend and adds service dependency ordering. |
.env.template |
Adds new replication-backend Keycloak client env placeholders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.