Vesting with inclusion of Cliff duration#101
Open
MisterDefender wants to merge 5 commits intoAbdelStark:mainfrom
Open
Vesting with inclusion of Cliff duration#101MisterDefender wants to merge 5 commits intoAbdelStark:mainfrom
MisterDefender wants to merge 5 commits intoAbdelStark:mainfrom
Conversation
Owner
|
Thanks for the PR, can you please remove README modifications specific to your fork ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains Fix for inclusion of cliff duration in complete vesting duration.
Use unchecked block: unchecked for arithmetic operations can save gas by skipping overflow checks. Since we are just incrementing a count, and assuming the vesting count will not reach near the uint256 limit, you can safely use unchecked.