Address all 86 review items from Go operator rewrite PR

.cz.yaml

@@ -1,12 +1,11 @@
 ---
 commitizen:
   annotated_tag: true
-  bump_message: "bump(release): v$current_version \u2192 v$new_version"
+  bump_message: "bump(release): v$current_version → v$new_version"
   name: cz_conventional_commits
   tag_format: $major.$minor.$patch$prerelease
   update_changelog_on_bump: true
-  version: 1.1.1
+  version: 2.0.0
   version_files:
-  - build.gradle:version
   - charts/locust-k8s-operator/Chart.yaml:appVersion
   - charts/locust-k8s-operator/Chart.yaml:version

.dockerignore

@@ -0,0 +1,34 @@
+# More info: https://docs.docker.com/engine/reference/builder/#dockerignore-file
+
+# Test files
+test/
+*_test.go
+
+# Documentation
+docs/
+*.md
+LICENSE
+
+# Git
+.git/
+.gitignore
+
+# IDE
+.idea/
+.vscode/
+
+# CI
+.github/
+.golangci.yml
+
+# Build artifacts
+bin/
+cover.out
+coverage.out
+
+# Planning
+.planning/
+
+# Python
+venv/
+__pycache__/

.editorconfig

@@ -0,0 +1,29 @@
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+charset = utf-8
+trim_trailing_whitespace = true
+
+[*.go]
+indent_style = tab
+indent_size = 4
+
+[*.{yaml,yml}]
+indent_style = space
+indent_size = 2
+
+[*.{md,markdown}]
+trim_trailing_whitespace = false
+
+[Makefile]
+indent_style = tab
+
+[Dockerfile]
+indent_style = space
+indent_size = 4
+
+[*.sh]
+indent_style = space
+indent_size = 2

.github/ct.yaml

@@ -1,3 +1,3 @@
 debug: true
 validate-maintainers: false
-helm-extra-args: --timeout 120s
+helm-extra-args: --timeout 300s

.github/workflows/ci.yaml

@@ -20,9 +20,7 @@ jobs:
   build-go:
     name: 🏗️ Build Go Operator
     runs-on: ubuntu-latest
-    defaults:
-      run:
-        working-directory: locust-k8s-operator-go
+    timeout-minutes: 30
     steps:
       - name: 📂 Checkout repo
         uses: actions/checkout@v4
@@ -33,7 +31,7 @@ jobs:
       - name: 🔧 Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version-file: locust-k8s-operator-go/go.mod
+          go-version-file: go.mod
 
       - name: 📥 Download dependencies
         run: go mod download
@@ -42,7 +40,6 @@ jobs:
         uses: golangci/golangci-lint-action@v8
         with:
           version: v2.1.0
-          working-directory: locust-k8s-operator-go
 
       - name: 🛠️ Build
         run: make build
@@ -54,19 +51,27 @@ jobs:
         if: always()
         uses: codecov/codecov-action@v5
         with:
-          files: locust-k8s-operator-go/cover.out
+          files: cover.out
           flags: go-unit-tests
           name: go-coverage
           fail_ci_if_error: false
 
+      - name: 📦 Upload Go test artifacts on failure
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: go-test-artifacts
+          path: |
+            cover.out
+          retention-days: 7
+
   # ============================================
   # Helm Chart Lint & Test
   # ============================================
   lint-test-helm:
     name: 🌊 Lint & Test chart
     runs-on: ubuntu-latest
-    needs:
-      - build-go
+    timeout-minutes: 30
     steps:
       - name: 📂 Checkout
         uses: actions/checkout@v4
@@ -108,19 +113,18 @@ jobs:
         if: steps.list-changed.outputs.changed == 'true'
         uses: actions/setup-go@v5
         with:
-          go-version-file: locust-k8s-operator-go/go.mod
+          go-version-file: go.mod
 
       - name: 🛠️ Install ko
         if: steps.list-changed.outputs.changed == 'true'
         uses: ko-build/setup-ko@v0.7
 
       - name: 🐳 Build operator image with ko
         if: steps.list-changed.outputs.changed == 'true'
-        working-directory: locust-k8s-operator-go
         env:
           KO_DOCKER_REPO: lotest/locust-k8s-operator
         run: |
-          CHART_VERSION=$(grep '^appVersion:' ../charts/locust-k8s-operator/Chart.yaml | awk '{print $2}' | tr -d '"')
+          CHART_VERSION=$(grep '^appVersion:' charts/locust-k8s-operator/Chart.yaml | awk '{print $2}' | tr -d '"')
           ko build ./cmd --local --bare --tags=${CHART_VERSION}
 
       - name: 📦 Load image into kind cluster
@@ -132,11 +136,23 @@ jobs:
       - name: 🚀 Run chart-testing (install)
         run: ct install --target-branch ${{ github.event.repository.default_branch }} --config .github/ct.yaml --helm-extra-set-args "--set=image.pullPolicy=Never"
 
+      - name: 📦 Collect kind cluster logs on failure
+        if: failure() && steps.list-changed.outputs.changed == 'true'
+        run: kind export logs kind-logs --name chart-testing
+
+      - name: 📦 Upload Helm test artifacts on failure
+        if: failure() && steps.list-changed.outputs.changed == 'true'
+        uses: actions/upload-artifact@v4
+        with:
+          name: helm-test-artifacts
+          path: |
+            kind-logs/
+          retention-days: 7
+
   docs-test:
     name: 📚 Test documentation
     runs-on: ubuntu-latest
-    needs:
-      - lint-test-helm
+    timeout-minutes: 15
     steps:
       - name: 📂 Checkout
         uses: actions/checkout@v4
@@ -161,3 +177,12 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           python -m mkdocs build
+
+      - name: 📦 Upload docs build artifacts on failure
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: docs-build-artifacts
+          path: |
+            site/
+          retention-days: 7

.github/workflows/go-test-e2e.yml

@@ -4,38 +4,58 @@ on:
   push:
     branches: [main, master]
     paths:
-      - 'locust-k8s-operator-go/**'
+      - 'cmd/**'
+      - 'api/**'
+      - 'internal/**'
+      - 'test/**'
+      - 'go.mod'
+      - 'go.sum'
+      - 'Makefile'
   pull_request:
     paths:
-      - 'locust-k8s-operator-go/**'
+      - 'cmd/**'
+      - 'api/**'
+      - 'internal/**'
+      - 'test/**'
+      - 'go.mod'
+      - 'go.sum'
+      - 'Makefile'
 
-defaults:
-  run:
-    working-directory: locust-k8s-operator-go
+permissions: read-all
 
 jobs:
   test-e2e:
     name: 🎯 Run E2E Tests
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - name: 📥 Clone the code
         uses: actions/checkout@v4
 
       - name: 🔧 Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version-file: locust-k8s-operator-go/go.mod
+          go-version-file: go.mod
 
-      - name: ☸️ Install the latest version of kind
-        run: |
-          curl -Lo ./kind https://kind.sigs.k8s.io/dl/latest/kind-linux-amd64
-          chmod +x ./kind
-          sudo mv ./kind /usr/local/bin/kind
-
-      - name: ✔️ Verify kind installation
-        run: kind version
+      - name: ☸️ Create Kind cluster
+        uses: helm/kind-action@v1.12.0
+        with:
+          cluster_name: locust-k8s-operator-test-e2e
+          wait: 120s
 
-      - name: 🎯 Running Test e2e
+      - name: 🔍 Verify go mod tidy
         run: |
           go mod tidy
-          make test-e2e
+          git diff --exit-code -- go.mod go.sum
+
+      - name: 🎯 Run E2E tests
+        run: make test-e2e
+
+      - name: 📦 Upload E2E test artifacts on failure
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: e2e-test-artifacts
+          path: |
+            cover.out
+          retention-days: 7

.github/workflows/release.yaml

@@ -14,9 +14,9 @@ jobs:
   publish-image:
     name: 🐳 Publish image
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     permissions:
       contents: read
-      packages: write
     env:
       DOCKER_IMAGE: lotest/locust-k8s-operator
     steps:
@@ -26,10 +26,10 @@ jobs:
       - name: 🔧 Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version-file: locust-k8s-operator-go/go.mod
+          go-version-file: go.mod
 
       - name: 🔧 Setup ko
-        uses: ko-build/setup-ko@v0.6
+        uses: ko-build/setup-ko@v0.7
 
       - name: 🔐 Login to Docker Hub
         uses: docker/login-action@v3
@@ -38,18 +38,19 @@ jobs:
           password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: 📦 Build and push with ko
-        working-directory: locust-k8s-operator-go
         env:
           KO_DOCKER_REPO: ${{ env.DOCKER_IMAGE }}
         run: |
-          ko build ./cmd/main.go \
+          ko build ./cmd \
             --platform=linux/amd64,linux/arm64 \
             --bare \
             --tags=${{ github.ref_name }},latest,${{ github.sha }}
 
   helm-chart-release:
     name: 🌊 Publish Helm chart
     runs-on: ubuntu-latest
+    timeout-minutes: 15
+    needs: [publish-image]
     permissions:
       contents: write
     steps:
@@ -76,9 +77,7 @@ jobs:
           helm package charts/locust-k8s-operator --app-version=${VERSION} --version=${VERSION} --destination=.cr-release-packages
 
       - name: 🎉 Run chart-releaser
-        # switch back to helm/chart-releaser-action when https://github.com/helm/chart-releaser-action/pull/109 is merged
-        # Waiting for a new release to include changes coming from https://github.com/helm/chart-releaser-action/commit/38cfeacdbbd62d13ec773fcdee1435ff5846c554
-        uses: askcloudarchitech/chart-releaser-action@skip-packaging-option
+        uses: helm/chart-releaser-action@v1
         with:
           skip_packaging: true
         env:
@@ -87,6 +86,7 @@ jobs:
   docs-release:
     name: 📚 Publish documentation
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     permissions:
       contents: write
     steps: