Skip to content

renamed src to the appropriate module name as to not cause confusion#165

Closed
jakob1379 wants to merge 1 commit intoAbe404:masterfrom
jakob1379:jga-rename-src-to-module-name
Closed

renamed src to the appropriate module name as to not cause confusion#165
jakob1379 wants to merge 1 commit intoAbe404:masterfrom
jakob1379:jga-rename-src-to-module-name

Conversation

@jakob1379
Copy link
Contributor

As mentioned in #164 there are risks in mixing flat and src layout. Sticking to one will improve clarity for future contributors and not cause path confusion or improper imports by tools inferring module names from the src/ folder

@Abe404
Copy link
Owner

Abe404 commented Feb 13, 2025

I understand that this is resolved now.

From the article you linked:

/my-monorepo
    /project1
        /src
        /tests
    /project2
        /src
        /tests
    /shared
        /src
    /scripts
    /docs

So in our case we have

/root_painter
    /trainer
        /src
        /tests
    /painter
        /src
        /tests (ok this doesn't exist yet, but we can create it when we
have them)
    /docs

Kind regards,
Abraham

@Abe404 Abe404 closed this Feb 13, 2025
@jakob1379 jakob1379 deleted the jga-rename-src-to-module-name branch March 5, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants