Skip to content

[Bugfix] Pie chart flicker on changing selected section #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sam1463 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Bugfix] Pie chart flicker on changing selected section #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d90b05
render full bigger pie instead of just selected section
sam1463 Sep 3, 2025
0c6a5a0
don't duplicate labels
sam1463 Sep 7, 2025
db85180
show label for all sections
sam1463 Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/PieChart/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,18 +211,12 @@ export const PieChart = (props: PieChartPropsType) => {
setTouchY={setTouchY}
tooltipSelectedIndex={tooltipSelectedIndex}
setTooltipSelectedIndex={setTooltipSelectedIndex}
data={[
{
...props.data[selectedIndex],
},
{
value: total - props.data[selectedIndex].value,
peripheral: true,
strokeWidth: 0,
},
]}
data={props.data.map((section, index) => ({
...section,
strokeWidth: index === selectedIndex ? undefined : section.strokeWidth,
peripheral: index !== selectedIndex,
}))}
radius={radius + extraRadius}
initialAngle={startAngle}
innerRadius={props.innerRadius || radius / 2.5}
isBiggerPie
setSelectedIndex={setSelectedIndex}
Expand Down
3 changes: 1 addition & 2 deletions src/PieChart/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ export const PieChartMain = (props: PieChartMainProps) => {
) : (
data.map((item, index) => {
const {sx, sy, ax, ay} = coordinates[index];
if (isBiggerPie && index) return null;
return (
<Path
key={index + 'a'}
Expand Down Expand Up @@ -235,7 +234,7 @@ export const PieChartMain = (props: PieChartMainProps) => {
item.pieInnerComponent ?? props.pieInnerComponent;
const pieInnerComponentHeight = props.pieInnerComponentHeight ?? 0
const pieInnerComponentWidth = props.pieInnerComponentWidth ?? 0
if (isBiggerPie && index) return null;
if (isBiggerPie && index !== props.selectedIndex) return null;
if (!props.data[index].value) return null;
let mx =
cx * (1 + Math.sin(2 * pi * mData[index] + initialAngle));
Expand Down