#247 Implement basics of FlowReader #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created new module Info * the new modul added to JaCoco and CI routines
* JaCoCo exclusion for model
* created Provider to query the data from server * support for Future, IO, and ZIO based providers * work in progress
* fixed license headers
…endpoints-from-info-module
…endpoints-from-info-module
lsulak
reviewed
Feb 17, 2025
reader/src/test/scala/za/co/absa/atum/reader/implicits/PaginatedResponseImplicitsTest.scala
Outdated
Show resolved
Hide resolved
lsulak
reviewed
Feb 17, 2025
reader/src/test/scala/za/co/absa/atum/reader/implicits/PaginatedResponseImplicitsTest.scala
Outdated
Show resolved
Hide resolved
lsulak
reviewed
Feb 17, 2025
lsulak
reviewed
Feb 17, 2025
reader/src/test/scala/za/co/absa/atum/reader/FlowReaderUnitTests.scala
Outdated
Show resolved
Hide resolved
lsulak
reviewed
Feb 17, 2025
reader/src/test/scala/za/co/absa/atum/reader/implicits/PaginatedResponseImplicitsTest.scala
Outdated
Show resolved
Hide resolved
benedeki
changed the base branch from
feature/247-paging-in-reader
to
master
* addressed PR comments
benedeki
removed
work in progress
reader/src/main/scala/za/co/absa/atum/reader/core/PartitioningIdProvider.scala
Outdated
Show resolved
Hide resolved
reader/src/main/scala/za/co/absa/atum/reader/exceptions/RequestException.scala
Show resolved
Hide resolved
| package za.co.absa.atum.reader.requests | ||
|
|
||
| object QueryParamNames { | ||
| val limit = "limit" |
Collaborator
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
Yes, and also why not making them final?
lsulak
reviewed
Feb 28, 2025
Collaborator
lsulak
left a comment
lsulak
left a comment
There was a problem hiding this comment.
Review finished, just few very very minor Qs / notes
| * @param offset - offset of the page (starting position) | ||
| * @return - a page of checkpoints | ||
| */ | ||
| def getCheckpointsOfNamePage(checkpointName: String, pageSize: Int = 10, offset: Long = 0): F[RequestResult[PaginatedResponse[CheckpointWithPartitioningDTO]]] = { |
Collaborator
There was a problem hiding this comment.
why not to have just 1 function with checkpointName being Option[String] ?
Contributor
Author
There was a problem hiding this comment.
I see it as inconvenient call.
And this way it clearly differentiate in the function name when only name-filtered entries are requested,
But can be unifies if seen as preferential.
Collaborator
There was a problem hiding this comment.
I see it as: little convenience for users, little duplicity for developers. Less # of APIs & less code: better :D
But I don't mind, it's a matter of style, if you want to keep it I'm definitely okay with it
lsulak
approved these changes
Feb 28, 2025
salamonpavel
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlowReadeis now a simple class to just retrieve checkpoints of the identified flow.ApiPathsmoved from_Server_ to Modelbasic->coreCloses #247
Release notes:
FlowReaderimplemented to return the flow's checkpoints (requested and returned in a paginated form)