#305 Get-Ancestors-Server Functionality #312

ABLL526 · 2025-01-21T21:33:29Z

Added the getAncestors Functionality for the Server Portion

Closes #305
Depends on #311

Release notes:

Created endpoint /api/v2/partitionings/{partitioning_id}/ancestors to get the partitioning ancestors.

1. Made the necessary changes as mentioned by the team. 3. Made the necessary changes to the getAncestors Database functionality.

1. Made the necessary changes as mentioned by the team. 3. Made the necessary changes to the getAncestors Server functionality.

github-actions · 2025-01-21T21:36:22Z

JaCoCo model module code coverage report - scala 2.13.11

Overall Project	56.38%	🍏

File	Coverage
ApiPaths.scala	0%	🍏

github-actions · 2025-01-21T21:36:23Z

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project	78.98%	🍏

There is no coverage information present for the Files changed

github-actions · 2025-01-21T21:36:24Z

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project	95.16%	🍏

There is no coverage information present for the Files changed

github-actions · 2025-01-21T21:36:25Z

JaCoCo server module code coverage report - scala 2.13.11

Overall Project	68.54% `-10.42%`	🍏
Files changed	52.94%	❌

File	Coverage
PartitioningRepositoryImpl.scala	100%	🍏
PartitioningServiceImpl.scala	100%	🍏
PartitioningControllerImpl.scala	92.72%	🍏
GetFlowPartitionings.scala	69.54% `-63.79%`	❌
GetPartitioningAncestors.scala	69.54%	❌
SeqImplicits.scala	61.54%	❌

salamonpavel · 2025-01-28T11:03:50Z

database/src/main/postgres/runs/V0.3.0.2__get_ancestors.sql

@@ -0,0 +1,121 @@
+/*


I guess this shouldn't even be part of this PR as there is #311

salamonpavel · 2025-01-28T11:24:18Z

server/src/main/scala/za/co/absa/atum/server/api/database/runs/functions/GetAncestors.scala

+
+  object GetAncestorsResult {
+
+    @tailrec def resultsToPartitioningWithIdDTOs(


The very same code already exists in GetFlowPartitioning, maybe we could introduce some abstraction and reuse it here.

I like the idea.

salamonpavel · 2025-01-28T11:24:59Z

server/src/main/scala/za/co/absa/atum/server/api/http/ApiPaths.scala

    final val Measures = "measures"
    final val MainFlow = "main-flow"
+    final val Ancestors = "ancestors"
+    final val Parents = "parents"


salamonpavel · 2025-01-28T11:27:51Z

server/src/main/scala/za/co/absa/atum/server/api/http/Routes.scala

+          PartitioningController.getAncestors(partitioningId, limit, offset)
+        }
+      ),
+//      createServerEndpoint[


Not part of this PR (the commented-out code). This goes for multiple places. You can remove all the code unrelated to this PR I think...

salamonpavel

Please clean up this PR. It cannot contain unrelated code. You should introduce only code related to the server's part of get ancestor operation if that's what this PR is intended for.

server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryImpl.scala

server/src/test/scala/za/co/absa/atum/server/api/TestData.scala

- SeqImplicits

- SeqImplicits - ApiPaths

- SeqImplicits - ApiPaths - PartitioningController, PartitioningRepository, PartitioningService

- SeqImplicits - ApiPaths - PartitioningController, PartitioningRepository, PartitioningService, GetFlowPartitionings, GetPartitioningAncestors

# Conflicts: # server/src/main/scala/za/co/absa/atum/server/api/database/flows/functions/GetFlowPartitionings.scala # server/src/main/scala/za/co/absa/atum/server/api/http/Routes.scala # server/src/main/scala/za/co/absa/atum/server/api/v2/http/Endpoints.scala # server/src/main/scala/za/co/absa/atum/server/api/v2/repository/PartitioningRepositoryImpl.scala # server/src/test/scala/za/co/absa/atum/server/api/TestData.scala # server/src/test/scala/za/co/absa/atum/server/api/v2/http/GetPartitioningAncestorsEndpointV2UnitTests.scala

…05-Get-Ancestors-Server

This reverts commit e51582c.

Updated Jacoco Ignores

- "za.co.absa.atum.server.api.v2.service.PartitioningService", - "za.co.absa.atum.server.api.v2.repository.PartitioningRepository", - "za.co.absa.atum.server.api.v2.controller.PartitioningController"

…05-Get-Ancestors-Server

- Amended the `JacocoSetup.scala` excludes to include the following: - "za.co.absa.atum.server.api.v2.service.PartitioningService", - "za.co.absa.atum.server.api.v2.repository.PartitioningRepository", - "za.co.absa.atum.server.api.v2.controller.PartitioningController"

project/JacocoSetup.scala

server/src/main/scala/za/co/absa/atum/server/api/v2/http/Endpoints.scala

server/src/main/scala/za/co/absa/atum/server/model/PartitioningResult.scala

# Conflicts: # project/JacocoSetup.scala # server/src/main/scala/za/co/absa/atum/server/Main.scala # server/src/main/scala/za/co/absa/atum/server/api/v2/controller/PartitioningController.scala # server/src/main/scala/za/co/absa/atum/server/api/v2/controller/PartitioningControllerImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/v2/http/Endpoints.scala # server/src/main/scala/za/co/absa/atum/server/api/v2/repository/PartitioningRepository.scala # server/src/main/scala/za/co/absa/atum/server/api/v2/repository/PartitioningRepositoryImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/v2/service/PartitioningService.scala # server/src/main/scala/za/co/absa/atum/server/api/v2/service/PartitioningServiceImpl.scala # server/src/test/scala/za/co/absa/atum/server/api/v2/controller/PartitioningControllerUnitTests.scala # server/src/test/scala/za/co/absa/atum/server/api/v2/repository/PartitioningRepositoryUnitTests.scala # server/src/test/scala/za/co/absa/atum/server/api/v2/service/PartitioningServiceUnitTests.scala

- Added a Unit test for `resultsToPartitioningWithIdDTOs` Signed-off-by: ABLL526 <Liam.Leibrandt@absa.africa>

ABLL526 added 2 commits January 21, 2025 22:29

Added the getAncestors Database functionality.

bbba4ae

1. Made the necessary changes as mentioned by the team. 3. Made the necessary changes to the getAncestors Database functionality.

Added the getAncestors Server functionality.

becd6f2

1. Made the necessary changes as mentioned by the team. 3. Made the necessary changes to the getAncestors Server functionality.

ABLL526 requested review from Zejnilovic, benedeki, dk1844, lsulak and salamonpavel as code owners January 21, 2025 21:33

ABLL526 requested review from benedeki, lsulak and salamonpavel January 21, 2025 21:33

ABLL526 linked an issue Jan 21, 2025 that may be closed by this pull request

GET /partitionings/{partId}/parents -> returns all ancestors, not just direct ones #305

Closed

ABLL526 self-assigned this Jan 21, 2025

ABLL526 added enhancement New feature or request good first issue Good for newcomers DB Issues touching the Database part of the project Server Issues touching the server part of the project labels Jan 21, 2025

ABLL526 changed the title ~~305-Get-Ancestors-Server~~ $305 Get-Ancestors-Server Functionality Jan 21, 2025

ABLL526 changed the title ~~$305 Get-Ancestors-Server Functionality~~ #305 Get-Ancestors-Server Functionality Jan 21, 2025

salamonpavel reviewed Jan 28, 2025

View reviewed changes

lsulak reviewed Feb 6, 2025

View reviewed changes

server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryImpl.scala Outdated Show resolved Hide resolved

lsulak reviewed Feb 6, 2025

View reviewed changes

server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryImpl.scala Outdated Show resolved Hide resolved

lsulak reviewed Feb 6, 2025

View reviewed changes

server/src/test/scala/za/co/absa/atum/server/api/TestData.scala Outdated Show resolved Hide resolved

ABLL526 dismissed stale reviews from lsulak and salamonpavel via b80ff9a April 1, 2025 15:33

ABLL526 and others added 16 commits April 1, 2025 18:05

- Amended the JacocoSetup.scala to exclude the file:

aeab677

- SeqImplicits

- Amended the JacocoSetup.scala to exclude the file:

ac89fa7

- SeqImplicits - ApiPaths

- Amended the JacocoSetup.scala to exclude the file:

b9092e3

- SeqImplicits - ApiPaths - PartitioningController, PartitioningRepository, PartitioningService

- Amended the JacocoSetup.scala to exclude the file:

fb7634a

- SeqImplicits - ApiPaths - PartitioningController, PartitioningRepository, PartitioningService, GetFlowPartitionings, GetPartitioningAncestors

- Amended the JacocoSetup.scala to exclude the file:

93f049c

- SeqImplicits - ApiPaths - PartitioningController, PartitioningRepository, PartitioningService, GetFlowPartitionings, GetPartitioningAncestors

- Amended the code to be correct with the refactor.

1dc9121

Delete scripts/ATUM-Services_DEV_env.postman_environment.json

e51582c

- Amended the JacocoSetup.scala to ensure Correct Report generation.

2019d5d

Merge remote-tracking branch 'origin/305-Get-Ancestors-Server' into 3…

026fd34

…05-Get-Ancestors-Server

Revert "Delete scripts/ATUM-Services_DEV_env.postman_environment.json"

1317a4b

This reverts commit e51582c.

Delete scripts/ATUM-Services_DEV_env.postman_environment.json

96ffbfe

Merge branch 'master' into 305-Get-Ancestors-Server

f5694cc

Update JacocoSetup.scala

9e4e339

Updated Jacoco Ignores

Merge branch 'master' into 305-Get-Ancestors-Server

3215280

Merge branch 'master' into 305-Get-Ancestors-Server

05ab12f

lsulak mentioned this pull request Jul 23, 2025

GET /partitionings/{partId}/parents -> returns all ancestors, not just direct ones #305

Closed

ABLL526 and others added 3 commits July 24, 2025 14:19

- Amended the JacocoSetup.scala excludes to include the following:

72c1e0b

- "za.co.absa.atum.server.api.v2.service.PartitioningService", - "za.co.absa.atum.server.api.v2.repository.PartitioningRepository", - "za.co.absa.atum.server.api.v2.controller.PartitioningController"

Merge remote-tracking branch 'origin/305-Get-Ancestors-Server' into 3…

e03f21f

…05-Get-Ancestors-Server

lsulak reviewed Jul 25, 2025

View reviewed changes

project/JacocoSetup.scala Show resolved Hide resolved

lsulak reviewed Jul 25, 2025

View reviewed changes

server/src/main/scala/za/co/absa/atum/server/api/v2/http/Endpoints.scala Outdated Show resolved Hide resolved

lsulak reviewed Jul 25, 2025

View reviewed changes

server/src/main/scala/za/co/absa/atum/server/model/PartitioningResult.scala Show resolved Hide resolved

ABLL526 added 2 commits July 31, 2025 14:43

- Edits to the server portion since merging with master.

28e8571

- Added a Unit test for `resultsToPartitioningWithIdDTOs` Signed-off-by: ABLL526 <Liam.Leibrandt@absa.africa>

lsulak approved these changes Aug 1, 2025

View reviewed changes

ABLL526 merged commit fe9ec6b into master Aug 1, 2025
9 checks passed

ABLL526 deleted the 305-Get-Ancestors-Server branch August 1, 2025 12:04


		object GetAncestorsResult {

		@tailrec def resultsToPartitioningWithIdDTOs(

#305 Get-Ancestors-Server Functionality #312

#305 Get-Ancestors-Server Functionality #312

Uh oh!

Conversation

ABLL526 commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JaCoCo model module code coverage report - scala 2.13.11

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JaCoCo agent module code coverage report - scala 2.13.11

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JaCoCo reader module code coverage report - scala 2.13.11

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JaCoCo server module code coverage report - scala 2.13.11

Uh oh!

salamonpavel Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

ABLL526 Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

salamonpavel Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

benedeki Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

salamonpavel Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

ABLL526 Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

salamonpavel Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ABLL526 Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

salamonpavel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ABLL526 commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

salamonpavel Jan 28, 2025 •

edited

Loading