Feature/396 version endpoint #419
Conversation
salamonpavel
requested review from
ABLL526,
MatloaItumeleng,
Zejnilovic,
benedeki,
dk1844 and
lsulak
as code owners
|
Report: Report: server - scala:2.13.13
|
| ) | ||
| val configPassword = ConfigFactory.load().getConfig("postgres").getString("password") | ||
| logger.info(s"Successfully fetched password for Postgres from config: '${configPassword}' and now it will connect to ${this.getUrl}") | ||
| logger.info(s"Successfully fetched password for Postgres from config") |
There was a problem hiding this comment.
@lsulak removing the extended statement so that pwd (even if only the dummy one from config) isn't part of the output
There was a problem hiding this comment.
Ok, thank you, definitely none of this is needed and I should remove it earlier!
ABLL526
left a comment
ABLL526
left a comment
There was a problem hiding this comment.
LGTM, I like the feature.
While you are on adding build information. What you think about fixing the Readme badges as well? I know its not in the scope of this PR but very loosely related.
| lazy val server = { | ||
| val server = (projectMatrix in file("server")) | ||
| .enablePlugins(GitVersioning) | ||
| .enablePlugins(BuildInfoPlugin) |
There was a problem hiding this comment.
This is so nice - did you test it on DEV already? I'd like to push this forward as well as the Hikary & DB config changes tomorrow so we can see all of it on DEV.
| "info": { |
There was a problem hiding this comment.
it's really hard to work with this and finish code review in reasonable time. How about we somehow reformat this? Maybe even on git push or something like that so that it's deterministic and automatic
3 participants
Release notes:
Closes #396
Note: Sorry about the formatting in the collection's json file. Postman newly formats files like that. Added functionality there is the "Act: build-info - 200".