Skip to content

Conversation

@yruslan
Copy link
Collaborator

@yruslan yruslan commented Apr 30, 2025

Closes #759

@yruslan yruslan requested a review from Copilot April 30, 2025 06:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for ASCII file options and introduces a new self-check option for custom record extractor indexing.

  • Reorganized and updated the ASCII files options table with new option rows for ascii_charset, field_code_page:cp825, and minimum_record_length.
  • Removed duplicate option entries from the Multisegment files options section and added the enable_self_checks option.
Files not reviewed (11)
  • cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/reader/VarLenNestedReader.scala: Language not supported
  • cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/reader/parameters/CobolParameters.scala: Language not supported
  • cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/reader/parameters/ReaderParameters.scala: Language not supported
  • project/build.properties: Language not supported
  • spark-cobol/src/main/scala/za/co/absa/cobrix/spark/cobol/parameters/CobolParametersParser.scala: Language not supported
  • spark-cobol/src/main/scala/za/co/absa/cobrix/spark/cobol/reader/VarLenNestedReader.scala: Language not supported
  • spark-cobol/src/main/scala/za/co/absa/cobrix/spark/cobol/source/index/IndexBuilder.scala: Language not supported
  • spark-cobol/src/test/scala/za/co/absa/cobrix/spark/cobol/mocks/FixedRecordExtractor.scala: Language not supported
  • spark-cobol/src/test/scala/za/co/absa/cobrix/spark/cobol/mocks/FixedRecordExtractorBroken.scala: Language not supported
  • spark-cobol/src/test/scala/za/co/absa/cobrix/spark/cobol/mocks/FixedRecordExtractorNoIndex.scala: Language not supported
  • spark-cobol/src/test/scala/za/co/absa/cobrix/spark/cobol/source/integration/Test39RecordExtractorSelfCheck.scala: Language not supported

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

JaCoCo code coverage report - 'cobol-parser'

Overall Project 91.42% 🍏
Files changed 100% 🍏

File Coverage
VarLenNestedReader.scala 69.23% 🍏

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

JaCoCo code coverage report - 'spark-cobol'

File Coverage [87.11%] 🍏
IndexBuilder.scala 97.03% 🍏
VarLenNestedReader.scala 95.45% 🍏
CobolParametersParser.scala 85.4% 🍏
Total Project Coverage 81.99% 🍏

@yruslan yruslan merged commit 55eba12 into master Apr 30, 2025
6 checks passed
@yruslan yruslan deleted the feature/759-add-custom-record-extractor-self-check branch April 30, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add custom record extractor index support self-check

2 participants