FileSystem to be chosen based on the file system of Input Path A.#15
Open
petr-pokorny-absa wants to merge 1 commit intomasterfrom
Open
FileSystem to be chosen based on the file system of Input Path A.#15petr-pokorny-absa wants to merge 1 commit intomasterfrom
petr-pokorny-absa wants to merge 1 commit intomasterfrom
Conversation
petr-pokorny-absa
requested review from
OlivieFranklova and
tmikula-dev
as code owners
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
JaCoCo code coverage report - scala 2.12.17
|
JaCoCo code coverage report - scala 2.11.12
|
| val config = spark.sparkContext.hadoopConfiguration | ||
| val fs = FileSystem.get(config) | ||
| val fsFilePath = new Path(args.inputA) | ||
| val fs = fsFilePath.getFileSystem(config) |
Collaborator
Author
There was a problem hiding this comment.
plase create a separate fs instance per inputs and for output - it can be different fs - e.g. hdfs and s3 bucket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted change to the way the Hadoop
FileSystemis instantiated in theArgsParserutility. Instead of using the default file system from the Hadoop configuration, it now determines the file system based on the input path, which improves compatibility with multiple file system schemes (e.g., local, HDFS, S3).Overview
Release Notes