#133 Fix doobie error when status is not OK and data is missing #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo
|
| Overall Project | 57.47% -1.71% |
🍏 |
|---|---|---|
| Files changed | 73.53% | ❌ |
| File | Coverage | |
|---|---|---|
| StandardStatusHandling.scala | 100% | 🍏 |
| DBFunction.scala | 4.01% | 🍏 |
| UserDefinedStatusHandling.scala | 0% | ❌ |
JaCoCo
|
| Overall Project | 70.17% -24.2% |
🍏 |
|---|---|---|
| Files changed | 66.26% | ❌ |
| File | Coverage | |
|---|---|---|
| StatusWithData.scala | 100% -475% |
❌ |
| DoobieEngine.scala | 100% | 🍏 |
| DoobieQuery.scala | 100% | 🍏 |
| DoobieFunction.scala | 73.72% -5.95% |
❌ |
JaCoCo
|
| Overall Project | 91.42% | 🍏 |
|---|---|---|
| Files changed | 100% | 🍏 |
| File | Coverage | |
|---|---|---|
| SlickQuery.scala | 100% | 🍏 |
| SlickFunction.scala | 88.97% | 🍏 |
jakipatryk
requested review from
Zejnilovic,
benedeki,
dk1844,
lsulak,
miroslavpojer and
salamonpavel
as code owners
lsulak
reviewed
Feb 11, 2025
| r.map { | ||
| case statusWithData @ StatusWithData(_, _, Some(data)) => statusWithData.copy(data = Some(Some(data))) | ||
| case statusWithData @ StatusWithData(_, _, None) => statusWithData.copy(data = None) | ||
| } |
Collaborator
There was a problem hiding this comment.
this segment is very nice, including the doc and backward compatibility big - thank you!
lsulak
approved these changes
Feb 11, 2025
Collaborator
lsulak
left a comment
lsulak
left a comment
There was a problem hiding this comment.
I really couldn't find a single thing, not even minor / naming. Really good job, you have a great ability to understand and involve yourself into anything & quickly.
Perhaps wait for @salamonpavel and/or @benedeki for some further review/opinions, but basically something like this I had in my mind, for some reasons I found a bit more complicated way and didn't finish it :D
salamonpavel
approved these changes
Feb 12, 2025
Contributor
salamonpavel
left a comment
salamonpavel
left a comment
There was a problem hiding this comment.
Good job. Thank you.
benedeki
approved these changes
Feb 18, 2025
jakipatryk
deleted the
feature/133-fix-doobie-error-when-status-is-not-ok-and-data-is-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
Release Notes
StatusHandlingnow requires only actualFunctionStatusto be providedNULLread at column..." error when function with status is not returning the data if status is not OK